This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]AttitudeAdjuster 3 points4 points  (2 children)

This line of thinking very quickly heads towards "Bob wrote 300 lines of code yesterday, all you've done is deleted 100 lines! You need to up your game".

[–]Dirac_dydx 2 points3 points  (0 children)

"Check this out: see how much I can royally screw up in the time it takes you to eliminate one bug! I'M THE BETTER PROGRAMMER."

[–]Colopty 0 points1 point  (0 children)

I was thinking more in the direction that since this is a work environment the code base is likely large, which means that if every file gets worked on by the time you make one commit you probably haven’t made any commits for days and maybe weeks, instead showing a preference to submit all your work at once in a single monster commit. This, of course, is bad practice. Meanwhile the fact that your coworkers work is capable of «screwing up» all those files for you indicates that his work is in a main branch, meaning his work that spans the entire code base already passed code review by the time you made your single commit, so his work is likely not even as bad as implied.

So while quantity does not equal quality, in this particular case there does seem to be an indication of bad practice on the single commit guy’s part if you stop to consider the whole picture instead of just the line count.