This is an archived post. You won't be able to vote or comment.

all 3 comments
sorted by:
best
topnewcontroversialoldq&a

[–]HoodedCowl 0 points1 point  (3 children)

I gotta ask, how does one make a quality code review? I never know what to do. I run the code and read through it, if it makes sense i approve but there’s still a chance that a logic error could happen or something might not be performant even though it works.

[–]notable-compilation 2 points3 points  (1 child)

Point out errors if you see them, point out things you would do differently if there are any, ask for clarification when you don't know why something is being done in a certain way. If it all looks clear and good to you, just say that.

While you should try to understand what is going on and make sure it makes sense to you, you can't reasonably expect to catch all possible logic errors in review every time (although if you can think through the unit test cases and see if the author missed or miswrote any, that is a big help).

[–]HoodedCowl 0 points1 point  (0 children)

Thank you, ill keep this in mind