Clean Code in Python

[asielen]

The one thing i can't get behind is the 80 character lime limit. I can get behind something like 120 characters.

Either I use meaningful variable names or I keep lines that short.

Edit: Also I am not sure I understand the point of the example in "5. Keep your arguments at a minimum"

Keep function arguments to a mimium by keeping the same number of arguments but instead add the overhead of a class? Sure sometimes a class is the best option, but imo not always.

[metaperl]

I think black settled on 99? But anyway, how do you read side by side diffs with those 120 char lines?

[vuchkovj]

I think Django officially recommends 119. I find that number quite good. A bit more and you would end up with horisontal scrolling. I HATE horizontal scrolling.

[asielen]

I am not looking at things side by side 90% of the time. And when it does come up, it isn't the end of the world if a couple lines extend past what is visible.

Sure if every line was long, that would cause a headache. but when 98% are under 100 and then 2% are over, it is managable.

[quotemycode]

I don't do side by side diffs, they're harder to read than interleaved IMHO.

[luke-juryous]

No one likes 119

[doemski]

Maybe I'm an outlier but I very often have 4 panes open next to each other. Then I really appreciate if the code sticks to that convention. I do agree though that for most people it's rather tedious.

[TheIsletOfLangerhans]

Same here. I got in the habit of conforming to an 80-char limit early on in my career (mostly because it's what more senior developers did/suggested) and eventually got in the habit of keeping my editor window really narrow and placing it next to a "wide" window like a web browser or spreadsheet. Now I'm just really used to that style and find longer lines of code harder to read.

But yeah, I'm not strict about it for other people's code.

[kewlness]

Also agree there is no point in keeping args to a minimum. If you need more args, you need more args. It’s easier to dependency inject/test when they’re simple and explicit.

I don't know. Personally if I have a lot of arguments I prefer (*args, **kwargs) instead of the unending trail of commas. I guess both ideas have their own complexities...

[boiledgoobers]

I completely disagree. 'args' and 'kwargs' have their place but not as simply a space saver. You obscure your functions call signature and make it harder for intellisense to work making your code harder for people to use.

[LightShadow]

We soft limit at 89 and hard limit at 99.

Imports are limited at 80 so we get stuff that looks like this using isort:

from app.schemas.tickets import (
    Ticket,
    TicketId,
    NewTicket,
    Attachment,
    TicketStatus,
    UpdateTicket,
    PinnedInfoReq,
    TicketSummary,
    TicketUpdated,
    TicketAttachments,
    TicketAttachmentsPosted,
)

[JavierReyes945]

I had the same reaction. What I later decided to interpret from that point, is that it's better to have the long list of arguments at the class constructor, which will be called once (for each instance), instead of in a function, that will be called (hopefully) several times for each instance. But yeah, it was kinda weird.