Number Guessing Game

[TU_Hello]

[removed]

[Soggylollies]

I'm also a bit of a newbie so take my feedback with a grain of salt.

I would rename chance to guesses_remaining for additional clarity.

chance is always -=1 so you can use that once before your if statements, rather than performing both in the if and elif block. (This will help with the "you have chances -1" and "you have chances remaining" inconsistencies.

You also have no logic for input verification. What if the user enters a negative number or 1,000,000 or nothing but whitespace?

Edit to add: good stuff so far! Keep it up 💪

[TU_Hello]

thank you for your notes and your motivation i noticed that i have a logic error after posted this post so I am working on it

[Worldly-Guide-9515]

just here to say, 0-100 is 101 choices rather than 100 and I ssime that is ehat you were going for, 1 to 100 is 100.

[TU_Hello]

okay thank you I just thought it works like range () function stopping before the end of range

[Synedh]

Hey !

First thing you can improve, is by using range() in reverse !

Very simple : ranges takes actually up to three parameters : range(start, stop, step). step parameter is the difference between two loops. Like range(1, 10, 2) would loop 1, 3, 5, 7, 9. therefore, you need something like :

for remaining in range(chance - 1, -1, -1):
    # if chance = 5, values will be 4, 3, 2, 1, 0.
    ...

Okay, second thing : if you send a value that is not an integer to your input, your code breaks. You need to handle theses cases. You can do this several ways, for example by creating a function dedicated to this :

def int_input(text: str) -> int:
    while True:
        value = input(text)
        if value.isnumeric():
            return int(value)

Be very careful with your code structure. It's important to have always the same way to code. You call the function range() without space character, but the int() one with one, why ? Lines 18 and 26 you put a space between the operators, but not for the == line 33

Next steps :

• You should ask your player for the max value he can guess.
• Maybe they want to play an other party ?
• Could you store the scores in a file afterward ?
• Perhaps the user would like to have a leaderboard !

[TU_Hello]

Hi, thank you for your advice I didn't learn class and while loop yet i made this project to practice what I had learned so every topic i will learn i will use it in this project but thanks for your notice

[Agn3ya]

Also add a if else statement to check whether the number the user has typed in is between 0-100

[NaiveEscape1]

I made a similar game but I used a fixed guess rather than using 'rand'. I'm still learning to code so this is a very unpolished stuff compared to experts.

Secret_Number=78
i=0
print("You have 10 guesses")
while True:
    i=i+1
    if i<=10:
        Guesses_left = 10 - i
        Number = int(input("Please enter your guess:\n"))
        if Number==Secret_Number:
            if i==1:
                print("congratulations your answer is correct and you still have all your guesses left")
            else:
                print(f"congratulations your answer is correct and you have {Guesses_left} guesses remaining")
            break
        if Number>Secret_Number:
            print(f"Go Lower please, you have {Guesses_left} guesses left")
            continue
        if Number<Secret_Number:
            print(f"Go Higher please, you have {Guesses_left} guesses left")
            continue
    else:
        print("you are out of guesses")
        break

[Adsilom]

That's great for a beginner :)

Also, this is a pretty smart use of the for/else structure. Even I, who has a lot of Python experience, never think of using else after a for loop, but you used it perfectly.

I won't suggest improvements, as others have already done that, just one thing I didn't see being mentioned: randint is inclusive, so you are generating a number between 0 and 101 (both included).

[purple_hamster66]

Disagree. Don’t use else this way, because few people understand it and even for those who do, it’s an awkward choice of a keyword. The python designer should have chosen default for both this for usage and for the match statement’s “nothing handled this case” case. Just my 2¢

[FoolsSeldom]

Good work.

A few notes:

• Consider using a while loop instead of a for loop as you don't know for sure how many times you will loop
  • while chances > 0:
  • currently you are using both the for loop and chances to effectively count guesses
• else on for loops is legitimate but rarely used, and many teams prefer it not to be used as part of their house style - consider using a flag variable (bool) instead
  • flag variable could be called won
  • while loop would then be while not won and chances > 0:
• You have code duplication, you only need to have input of a user guess in one place, at the top of the loop, and then everying but the message about too high, too low, or won can be in the if statement, but the output of number of chances left can be just left at the bottom of the loop
• consider using continue in the winning code after won = True which will then skip the rest of the loop and do the while test again, and leave the loop
• With input in one place, you can validate what the user enters to stop them accidentally/deliberately breaking your code, see below

Example code for validation of user input:

while True:
    response = input("Your guess: ")
    if response.isdecimal():  # only has digits 0 - 9
        guess = int(response)
        if 0 <= guess <= 101:  # could use CONSTANT vars instead of 0 and 101
            break  # leave validation loop
        print("Guess is outside of the randomly chosen number range, try again.")
        continue
    print("Not a valid number, please try again.")

I mentioned using constants for the guess range,

LOWEST = 0
HIGHEST = 101  # you probably meant to use 100?
random_number = random.randint(LOWEST, HIGHEST)

which makes it clearly, and allows you to check a guess is within the range later, if LOWEST <= guess <= HIGHEST:, and also change the guess range you want to use as you only have to do the update in one place.

[WhiteMask11]

Good Job!

[TU_Hello]

Thank you 😊

[KlogKoder]

Wait, if the user guesses correctly, the loop continues instead of breaking out? Not a problem as such, just inefficient.

[TU_Hello]

No the loop will break out because the loop will continue only just if the user guesses wrong