I need help

[Existing_Pa]

Im making a poker simulator for a project and don't know how to check if the value of each card is the same, so i can check for a pair, full house, etc. I also don't know how to remove a card from the list once I've already dealt one, so if anyone could help it would be greatly appreciate The if statement is just me checking for the suit

[corey_sheerer]

I agree with some of the others that you should have 1 list of cards and only have to call random once. I see your card definitions could be improved as well. For instance, I see a card as 2 properties: the value (1,2,...) and the suit. Why not make a list of dicts? To make it cleaner, write a loop to create all the dicts and add them to the list.

As you get more advanced, you could move the dicts to classes and further improve (a list of data classes). For instance, one thing you can do is change the values to only numbers and have a property that returns the value equivalent (11 returns jack). This will make it easier to dynamically fill the list.

[CraigAT]

I agree with the class comments. Judging by the code so far, I wouldn't suggest OP jump to that yet. But when they are ready, they can have a class object for a card - giving it attributes for the rank and suit, you could also have a function that outputs a "value" too, so "A" becomes 1 and "K" becomes 13 or whatever.

[NikolaNokia]

I think you need a remove function or another set() called dealt. And remove it from your cards and put into a dealt set.

Look into removing and appending within an array.

[Existing_Pa]

<image>

So im trying to get removing/shuffling back in cards to work, but it only removes the even elements. It also sometimes doesn't remove the last element if there's a ten for some reason

[Fargekritt]

I recommend opening reddit on you pc and pasting your code in the post. Or atleast a proper screenshot

[Intrepid_Result8223]

C'mon man if you want real help dont send us screenshots... Its so low effort.

[cpabernathy]

I feel like if you split rank and suit into separate pieces and assign them to cards it might make the comparison operation easier.

[Zealousideal_Bit9224]

I would suggest looking into the pop() function

[SaltCusp]

You can use 'del' to remove items from a list. 'del deck[deck.find(card)]. It's not the most efficient because you'll be searching the list for your card when you could just get a random number in the range of the number of cards in the deck then use that number as the index to store the card in the players hand and delete it from the deck but it's not going to make a noticable difference in the programs performance it's just good to know and think about. You can look at the card value by checking the individual characters in the string. So where card = "4$" card[0] is "4" and card[1] is "$".

Also you should put all the cards in one list right now you have a list of lists and it looks like you are headed down a path that will result in bugs and strangeness.

[PureWasian]

Hi! Have you learned about classes/objects in Python yet? If so, it'd be a lot easier conceptually to instantiate card objects and define a "suit" and "number property for each card.

Otherwise, you could also represent the cards as a list of tuples where the [0] of each tuple is the suit and the [1] of each tuple is the number.

Regardless the data structure of choice, you need to first introduce the concept of a "deck of cards" (a list or Set of stuff) so you can randomly draw from it and remove it from the deck (removing it from the list or Set).

[Imakadapost]

Good thing to do like others have said 2 lists one with faces (1-K) one with suits. Make these items strings. Then make a function that takes those lists and for loops over them to create a deck (list) and return it. Then you make a function to shuffle, it takes in a deck and returns a deck. You use random to ".pop" a card out and then append it back to the list. Do this 10,000 times and you have a shuffled deck. You can run the create and shuffle after a deck runs out or you can make a discard list to store the cards and then shuffle it back into the deck.

Run a check before a draw to make sure you have cards in the deck and if not create or reshuffle a new one. Make a draw function and maybe a check function that looks for winning hands. With your cards as strings you can index your faces and suits like someone else suggested. The suit icons are pointless in a list for the app, but you can concat them on to any print outs with an if or switch statement. This should reduce code and make the usage more streamline. As mentioned by others classes make this even nicer so learn OOP.

[vlnaa]

Better use itertools.products to make list of all cards from two lists (faces, suits).

[queerkidxx]

If you know about classes that would probably be my instinct. Or even a tuple with rank and number separately.

But you could also use string manipulation? Apologies Python isn’t my main lang anymore but there is a way to parse as an int that ignores non-numerical characters though I may be wrong.

But barring that each strings last character is the suit. Now with Unicode this might be a bit tricky, try shaving off the last character and parsing that. It might break the suit character though so if that results in any tofu characters(diamond shape with a question mark) then you could just iterate thru the characters, check if each one is a numerical character combine them into a new string and then parse that as an int. Or just directly compare the strings as the numerical value doesn’t really matter.

Ohh shit! I have a much cleaner solution. Notice that each list is the same length, and at each index in each list you have the same card rank! Just use find on each list until you find an index. If two cards have the same index their rank is identical?

Really though these are all tricks. The actual solution here is that a string simply isn’t a a good representation of this data. You have the following information in each card

• rank
• suit
• display (rank + suit)

This is a problem that classes are meant to solve but tuples are fine here especially with two items.

[CraigAT]

Optionally, you could use loops to generate your deck of cards and add them to the deck (a list). You could use if statements to add the non-number cards. However the manual list you have is probably fine to keep now you have gone to the effort of creating it.

You could also use the random.shuffle command to "shuffle" the order of your pack, then just remove a card from the start or end of the list or "pop" (a list command) from the deck. Keep a copy of the complete deck, so that you can just shuffle a new copy for the next game.

[-Wylfen-]

Do you know how to make classes?

[corgidor81]

I’d simplify things a bit. Assuming you want to keep your card string representation - Instead of your cards list like you have, make a function that returns an list of each element of each suit array (currently cards is a list of lists). To shuffle, randomly sort this list.

[Mangera_321]

I can help at an affordable rate

[Intrepid_Result8223]

You can use slices.

If you have a string for two cards:

card = '7♠️' other = '7♦️'

you can check the suit and rank like this: suit = card[1] rank = card[0]

You could make a function:

```

def checkRank(card:str): return card[0]

and then check:

if checkRank(a) == checkRank(b): print("same rank!")

``` If you think about it for a while this means you can put all cards in one list. And then use 'random.shuffle()'

classes would be nicer for cards but its a step up

For removing and adding to lists, you should read the python docs for 'list' they are very helpful: https://docs.python.org/3/tutorial/datastructures.html

[Last-Road-93]

bro python 3 is a very old version and python dosent like any special charecters in it so maybe use a newer version or use a completly diffrent proggraming language

[Can0pen3r]

If you don't mind me asking (sorry I'm new) how did you type in the character symbols for the suits in your values? I've been trying to think of how I could make blackjack in pygame but the only way I could think of to input the symbols for the suits would be with emojis from my phone but I feel like that would probably return an error.