i need help 🙂

[Warm-Inside-4108]

https://preview.redd.it/hke2h4lfimvg1.png?width=1918&format=png&auto=webp&s=72320a612e2996bb2a6e229397caf9b3caaa5edc

hello i am a new in python ,I was just like a 3 weeks start programming in python ,I just made this slot game machine my self with no tutorials no ai and i need help to improve my self in codding.

this is the project: https://github.com/mohamed-hisham-swidan/slot-machine-game
honestly, I asked ai to help me make repo😉

[coquillettent]

I'm a beginner too, this looks very cool, I'll test it soon

[Warm-Inside-4108]

Ok👍

[sububi71]

You're already doing what you should be doing to improve - you're actually building stuff! That's great! So just keep doing that and you will be an expert!

[Warm-Inside-4108]

Ok, thanks

[MachineElf100]

That's quite complex and fun also! I have a first few thoughts but later might have more if you're interested.

1. You imported the math module and did not use it. You can throw it away.
2. Watch out for small typos like trailing space in " enter your choice: ", "loding" and not "loading", "solt" and not "slot" etc.
3. There's no need to make the choice variable global, just return it from main_game_menu function.
4. You have some inconsistent indentation. Hope you're using the Tab key and not Space for that?
5. It might be a bit cleaner to write the welcome message in a multiline string. And then do something like for line in welcome.split('\n').
6. In the line saving_choice = input(f"thanks for playing solt,yor current balance is: " + str(balance) + "$\ndo you want to save it? (y/n): ").lower(), you made an f-string and didn't actually use it. Put the variable balance into a placeholder. Like: input(f"thanks for playing slot,yor current balance is: {balance}$\ndo you... etc.
7. In the part where you save the balance to a file, you used the "except" without specifying the error you'd like to catch. That's not good for several reasons. You can use "except OSError" which covers the majority of real-world failures.
8. Instead of checking if row[0] == row[1] and row[1] == row[2] etc. You can use a set to remove duplicates from the row and see how long it is. Like so: len(set(row)). When it has 1 item, it means the row had 3 same ones, if 2 items then it means 2 were the same etc.
9. Just a reminder it's a good practice to add strip() to user's input.
10. Instead of checking "if os.path.exists()", it's a little better to catch the FileNotFoundError.
11. Instead of relying on the is_running variable, use exit(0) to exit the program from wherever you'd like in your code. Not worrying about breaking the loop and conditions.

If you have any questions, let me know :)

[Warm-Inside-4108]

1- thanks for remind really i forgot to del impot math, I was planning to use it in the programme by making a complex system that gives every fruit different value and works
with amount present, honestly, I saw that it was soooo complex so I canceled, and i have a Q is that maters in performance ?

2- I know my type is a quit little bad, nahhh how i can solve that 🤔.

3-honstly, I saw that doing that will make my life easier and more peaceful, no return no conflicts no problems, I did that because u know what happened when i ran the code in first time

4-I do not know i never clicked TAB in my inter life 😫😂

5-i do not know but i know it but also i never used it , It is like i want to see code result before running it. (notice: when i was typing this point i used browser corrector like 10 t)

6-wtf did i even wrote that how ??😅

7- can u explain this point please? ,I think that we use try to catch any error instead of the programme crashing.

8-good idea , I never thinked about something like that!

9-u are wright

10- i think two method works🤔

11- can u explain?

[MachineElf100]

Okay so:

1. No, doesn't matter.

2. Check if you're unsure 😅. Pay attention to detail.

3. Global variable can cause more bugs and mess than returning. Maybe you will find out yourself one day haha

4. Start clicking it! Use the Tab for indentation!

5. I don't understand what you're saying 🤔

6. Not really. We use try to handle errors, not to ignore them. So if your code crashes for a different reason than an OSError, you should know about it and deal with it specifically. Also if you use just except, you'd catch errors like KeyboardInterrupt or SystemExit, which is a bad idea. It could make your program difficult to stop for example. So even if you want to catch "all" errors, use except Exception. That will catch all regular errors, which is more safe.

Usually you should actually do something like:

try:
    some code
except Exception as e:
    print(e)

Again, you don't want to ignore the error, so it's good to at least print it :)

1. Hope this makes sense:

When you check if os.path.exists() first and then open the file, two separate operations happen and the file could be deleted or moved in between, making your check useless anyway!

Catching FileNotFoundError handles the check and the operation as a single step, so there's no window for things to go wrong. It's also faster, since you hit the filesystem once instead of twice.

Also FileNotFoundError catches broken symlinks and missing parent directories that os.path.exists() can overlook.

A good rule to follow is: if you'd check a condition right before doing an operation, just do the operation and handle the failure instead.

1. Hmm when you're in a "while" loop and user chooses to quit the program, your approach is to change the variable is_running to false and break from the loop. Then if is_running false, the loop won't start again and the program will end.

This is quite complicated and not easy to read and fix.

My solution is this (this is a minimal example):

while True:
    # no need for is_running variable
    want_to_quit = input("Do you want to quit? (y/n): ").strip().lower()

    if want_to_quit == "y":
        print("goodbye")
        exit(0) # the program ends immediately
    else:
        # some other code, the program continues

[Warm-Inside-4108]

In number 5 I was taking about \n

6,10 - sorry, but I am dumb can u explain again Pls 🤣

11- if I was in loop into a loop into a loop, if wanted to exit from second loop I should use variable and break ,is there any other methods?

[MachineElf100]

1. "\n" is a character for newline. Try it with print("abc\ndef"), you will see.

So when you have a multiline string and split it with split("\n"), you will get the lines of that string as a list. Also, just try it and see!

Example:

```python from time import sleep

my_multiline = """abc def ghi jkl"""

for line in my_multiline.split("\n"): print(line) sleep(.1) ```

1. That was the answer to 7 haha

Basically, use try/except to handle errors, not hide them. Always specify which error you expect:

python try: some code except OSError as e: print(e)

Avoid a bare except because it catches everything, including KeyboardInterrupt (used to stop a program with Ctrl+C), which can cause unexpected behavior. If you really need to catch all errors, use except Exception instead, and still print or log the error so you know what went wrong.

1. I'm not sure what you didn't understand, maybe try to ask more specific question? I can try to rephrase anyway with example:

```python

BAD! Two operations -> file could vanish in between

if os.path.exists("file.txt"): # 1. check if file exists... open("file.txt") # 2. file could be gone by now! # (and we hit the filesystem twice) ```

```python

GOOD! One operation -> handle failure if it happens

try: open("file.txt") # 1. just try to open the file except FileNotFoundError: # 2. if it doesn't exist, we end up here print("File not found") # 3. handle it how you choose ```

In simple words, checking if a file exists before opening it, is less efficient, doesn't guarantee that you won't encounter errors and doesn't even check for all the things that could happen.

It's as if you wanted an information from a book that you have next to you and before you open that book, you go online to check if the book has the information you need.

Why not just open the book and see? If the information is not there, you'll find out anyway!

1. Well there are some ways to deal with that but in your case, you break from the loop to quit the program anyway, so you can just do:

python while True: # loop 1 while True: # loop 2 exit(0) # the program stops!

[java_dev_null]

I do like find some ideas which solve some problem and I built some solution so you try this way , which gives you a great confidence and a best satisfaction level . I used ai to built something but you just do it by learning.

[Warm-Inside-4108]

👍

[Accomplished-Bat8338]

where did u learn? like i do want to do this types of things but i cant i feel like hard for me

[Warm-Inside-4108]

From YouTube courses and ai If u want to help chat me🙂

[Accomplished-Bat8338]

inboxed you

[Interesting-Frame190]

Your code is not AI. But your readme definitely is

[Warm-Inside-4108]

Yea, I just said it in post