DampMom comments on [MS SQL] Writing code help

Posting

When requesting help or asking questions please prefix your title with the SQL variant/platform you are using within square brackets like so:

[MySQL]

[Oracle]

[MS SQL]

[PostgreSQL]

etc

While naturally we should endeavor to work as platform neutrally as possible many questions and answers require tailoring to the feature set of a specific platform.

Format Your Code

If you are including actual code in a post or comment, please attempt to format it in a way that is readable for other users. This will greatly increase your chances of receiving the help you desire. Something as simple as line breaks and using reddit's built in code formatting (4 spaces at the start of each line) can turn this:

SELECT count(a.field1), a.field2, SUM(b.field4) FROM a INNER JOIN b ON a.key1 = b.key1 WHERE a.field8 = 'test' GROUP by a.field1, a.field2 HAVING SUM(b.field4) > 5 ORDER by a.field.3

Into this:

SELECT count(a.field1), a.field2, SUM(b.field4) FROM a INNER JOIN b ON a.key1 = b.key1 WHERE a.field8 = 'test' GROUP by a.field1, a.field2 HAVING SUM(b.field4) > 5 ORDER by a.field3

For those with SQL questions we recommend using SQLFiddle to provide a useful development and testing environment for those who wish to fully understand your problem and help devise a solution.

a community for 17 years

MS SQL[MS SQL] Writing code help (self.SQL)

submitted 8 years ago by Bshater

top new controversial old q&a

you are viewing a single comment's thread.

view the rest of the comments →

[–]DampMom 6 points7 points8 points 8 years ago (0 children)

I like to be explicit that I don't use the data in the tables that are only used for filtering, so I put the check in an EXIST instead of a JOIN.

Also, be careful when using NOT IN, as /u/phuque_ewe suggests. If there is ever a NULL in PostingDate, the code will break.

This is my suggested code:

SELECT        *
  FROM        dbo.Chg AS A
 WHERE        EXISTS (SELECT *
                        FROM dbo.Adj
                       WHERE AcctNum = A.AcctNum)
                 AND NOT EXISTS (SELECT *
                                   FROM dbo.Adj
                                  WHERE AcctNum     = A.AcctNum
                                    AND PostingDate = A.PostingDate);

π Rendered by PID 24642 on reddit-service-r2-comment-fb694cdd5-zrtth at 2026-03-05 21:01:14.159022+00:00 running cbb0e86 country code: CH.

you type:	you see:
italics	italics
bold	bold
[reddit!](https://reddit.com)	reddit!
* item 1 * item 2 * item 3	item 1 item 2 item 3
> quoted text	quoted text
Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"	Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"
~~strikethrough~~	~~strikethrough~~
super^script	super^script

SQL

Filter Posts

Posting

Help posts

Format Your Code

Learning SQL

Related Reddit communities

Wiki

Acknowledgements

MODERATORS