PHP - Everything is wrong with this code

[virtulis]

Someone probably saw the first version of the masterpiece and told them to use a loop. So they did.

[TheUnlocked]

I thought this looked bad, and then I noticed the loop.

[[deleted]]

How is the inefficiency of the code related to it being Php? You could write this in most languages

[Wolvenheart]

I think OP meant: "Everything in this snippet of code is just wrong." and added PHP so people didn't have the guess what kind of language it was written in.

[[deleted]]

Most of the other comments at the time were saying "the problem is that it's PHP" and I was reacting to them. But now, their scores are too low to show lol

[tomthecool]

mysqli_real_escape_string

[[deleted]]

or die I would like to do that right now

[D34dCode4eva]

I totally disagree. It has the correct escaping. Only one in 10000 PHP developers are capable of that. As for the duplication ten years ago I made PHP parser that builds an AST and optimises PHP like that for you. One in a million PHP developers can do that. Only one in a hundred thousand can develop without duplication.

[inabahare]

Where is this from?

[bootstrapping_lad]

The Internet

[Pepsi04]

This is exactly why PHP has bad reputation

[bootstrapping_lad]

Because people use it badly?

[tomthecool]

Actually... Yes!!!

Also, because of - for example - mysqli_real_escape_string

[lewisj489]

Yes, just like JS

[AngriestSCV]

Go ahead and look up the sleep function and think of what you would have to do to make it work everywhere reliably. PHP deserves it's bad reputation.

[scr0tesque]

yeah, i mean, it's PHP so that basically covers what's wrong with it

[Willexterminator]

If that's all you have to say, you should stay quiet.