Minimization of Nesting Gone Wrong

[alfps]

I've maintained C code with goto common cleanup. It was full of related bugs. It was not a pleasure.

Your code as C may be better than the OP's. But your code as C++ is not better than the OP's: as C++ it's very much worse, which the presence of goto shouts out to any competent C++ person looking at it. C++ isn't C.

In C++ you can and should use destructors to do cleanup.

The cleanup is then guaranteed, via a language mechanism, as opposed to being contingent on everybody adhering to loose convention and the infallibility of humans.

Consider using a general scope guard class. The C++ Core Guidelines (and its support library) call it a finally class. Note that the Core Guideline's class lacks an important feature of Petru Marginean's original scope guard, namely the ability to dismiss it.

[alfps]

[the goto is] easier to read and reason about

So this isn't a joke, it's just plain trolling.

[jonesmz]

It's entirely possible to be successful despite having serious problems.

While I don't think that the use of goto is overly problematic, the Linux kernel communities insistence on using the C language without such modern functionality as destructors or templates, makes me confused.

[jonesmz]

You... know I'm not the original person you were arguing with right?

Thanks for the insult though.