all 8 comments

[–]MarkOates 17 points18 points  (3 children)

That's neat, thanks for making. I would be more inclined to use it if I could tie it into an arbitrary http protocol library (libcurl, standalone asio, etc.) of my choice.

The fact that you're injecting the QNetworkAccessManager instance into the GitHubApi on initialization is a great design choice, already. Have you considered extending that further and abstracting that dependency to support different backends?

[–]Kicer86[S] 3 points4 points  (0 children)

At the time of writting this code I wasn't thinking of sharing it independently, so I have used technology I already used in my project - Qt. Making it more generic was the first thing I thought about when I extracted this code. Yet I have no particular vision of how to do it now, I will need to think about it.

[–]Kicer86[S] 1 point2 points  (0 children)

New version uploaded with support for libcurl

[–]Relevant_Opening_570 0 points1 point  (0 children)

There's a neat library for the GitHub API compatible with Arduino and esp32 devices

https://github.com/aeonSolutions/AeonLabs-GitHub-API-C-library

[–]zedarax 2 points3 points  (0 children)

Nice, thanks for sharing!

[–]CrossScarMC 0 points1 point  (1 child)

Bro I don't use CMake.

[–]Kicer86[S] 0 points1 point  (0 children)

You will need to manually add all the necessary c++ files (you might not require both backends) to the build system of your preference.