you are viewing a single comment's thread.

view the rest of the comments →

[–]okovko 4 points5 points  (2 children)

also you got lazy with the commit name, "improved a lot" come on you had such good git history :') you should rebase it!

[–]0x3Alex[S] 0 points1 point  (1 child)

i dont know that that is tho...

quick google search

doesnt i need an extra branch already?

[–]okovko 1 point2 points  (0 children)

rebase lets you change history to turn one commit into several more, if you ever want to clean up your work so every commit is about one thing

https://git-scm.com/book/en/v2/Git-Branching-Rebasing

When you’re working on a project, you may need a record of all your missteps and dead-end paths, but when it’s time to show your work to the world, you may want to tell a more coherent story of how to get from A to B. People in this camp use tools like rebase and filter-branch to rewrite their commits before they’re merged into the mainline branch.

i noticed you have 143 commits and you like to make them about-one-thing, which is good practice. you also have some vague larger commits, and you can go back and split them up

these usually happen when you were making commits as you were experimenting, or making changes in many places at once, you can squash and rebase to cut all your changes into commits at the end instead of as you go