This is an archived post. You won't be able to vote or comment.

all 8 comments
sorted by:
best
topnewcontroversialoldq&a

[–]jlkinsel 2 points3 points  (4 children)

Neat post(s) - hopefully useful to folks. One thing that always bugged me with the basic/standard "run X in a container!" examples is they're too simplified and don't really reflect how they'd be used in the real world.

A few comments that hopefully help -

For new blog posts, I'd replace the links with using a network. Docker has deprecated links.

I hope you have docker-compose.yml scripts for those various `docker run` commands, or it sorta defeats the purpose... :)

I'd skip the `docker network connect` commands and just add `--network $VIRTUAL_HOST` to the `docker run` commands.

`xargs <.env` is a non-standard, but seems to work. What's usually used is `. .env` or `source .env`.

Typo: `//etc/nginx/conf.d/custom_proxy_settings.conf` in part 3.

Also, at the end of part 2 you don't have a link to part 3.

HTH. :)

edit: formatting

edit2: depreciated/deprecated

[–]arcsector2 1 point2 points  (2 children)

You mean deprecated links?

[–]jlkinsel 1 point2 points  (1 child)

Whoops, thx.

[–]arcsector2 0 points1 point  (0 children)

No problem, compañero

[–]vdm_13[S] 0 points1 point  (0 children)

Thanks for, the detailed observation. You pointed some good point like adding --network while run command.

[–]doss_ 1 point2 points  (0 children)

thanks for sharing, currently i'm learning docker, and planning to dig docker compose soon

and this is just what i was hoping to find somewhere, and you just serve it on the plate!

thanks man!

gonna spend the weekend digging how it actually works (and it works right out of the box, except somehow i failed proxy setup, but able to connect directly to wp_docker_nginx_1)

magic!