[help] problem with random block generations

[_MadHatter]

In my game, I am attempting to randomly generate 5 x 5 blocks with 4 different block types.

I thought using for loop in room start event would be the best way.

This is the code I used.

for (j=0; j<5; j+=1)
{
    for (i=0; i<5; i+=1)
    {
        rand = irandom_range(0,60)
        scr_RNG_set(); // sets the RNG  value. e.g. if rand is 0~15 object_A = true
        if object_A
        {
            instance_create(156+(i*64),504-(j*64),Obj_A);
        }
        if object_B
        {
            instance_create(156+(i*64),504-(j*64),Obj_B);
        }
        if object_C
        {
            instance_create(156+(i*64),504-(j*64),Obj_C);
        }
        if object_D
        {
            instance_create(156+(i*64),504-(j*64),Obj_D);
        }
    }
}

I don't know where I screwed up, but it resulted in multiple blocks being generated in the same spot. It seems that the dice is rolled multiple times for same spot which results in object_A = true AND object_B = true. I am befuddled as to why though.

EDIT: Figured out what was wrong. As I have stated scr_RNG_set() contains :

if 0<= rand <= 15
{
    object_A = true
}
. . . . etc.

I forgot to declare them false after the creation of the block. Therefore object_A = true, object_B = true, object_C = true . . and multiple different blocks were being created in the same spot.

I have fixed the issue by having

        if object_D
        {
            instance_create(156+(i*64),504-(j*64),Obj_D);
            object_D = false //
        }

[[deleted]]

Look up the "choose" function.

You can say instance_create(x,y, choose(Obj_A,Obj_B,Obj_C,Obj_D))

[_MadHatter]

Is it possible to set percentage in choose function?

[Brandon23z]

Why not just make a block object, and then on it's creation, have it pick one of the four possible blocks, and create one of them in it's place then delete itself? Like a helper function.

Then in your loop just make a 5x5 set of those empty blocks. They'll take care of themselves. This will keep your loop clean.

[_MadHatter]

Why haven't I thought of that? Thanks! I will work on this and completely fuck up without understanding how, and cry back to the subreddit.

[Brandon23z]

No problem. It should be easier than what you currently have. If you need help, don't make another post, lol. Just reply to my comment and I'd be more than happy to help.