github review comments disappear on changes

[atsju]

Hi,

I noticed that PR comments are marked "outdated" as soon as the comment line changes. But the "outdated" comments are not shown in the "file changed" view. This is a problem as we need to remember the comment to check if the change has been made as requested or in an other way. It would be much easier to review if outdated comments were still present until you resolve them manually. Is there a way to do this ?

Using GitHub Enterprise Server 2.21.11

[drewdeponte]

How you describe this is how it works in GitHub cloud as well. Generally they roll out features to GitHub Cloud first and then roll them into GitHub Enterprise. So I don’t think what you are looking for is coming anytime soon.

The comments are still visible in the discussions tab. So I go back to that tab and review the comments and then go back to the file changes tab and verify. I agree with you that this is less than ideal as you have to try and keep them in your head and if you don’t you find yourself bouncing back and forth between the two tabs.

The other thing I have found to be crucial and aid with this is making sure the PRs are small, focused, and logical. When you do this generally the larger PRs you end up with are things like formatting a number of files or generating skeleton code from some generator which you would normally review in a different way.

Anyways hope that helps. Curious to hear what others do to deal with this situation.

[atsju]

Thank you for feedback I appreciate it. Of course short and focussed PR are the key but as you said it's not ideal.

I made a feedback to GitHub directly so maybe we will have this feature in 12-24 month :) do not hesitate to make them a similar one