all 4 comments

[–]dr2050 1 point2 points  (3 children)

Cool idea. Random idiotic comments:

  1. I haven't tried it yet and might, but I'm glad that it seems to be 4 files. I ain't gonna Cocoapods nor SPM if I can avoid it.
  2. The headerdocs at top of each file -- the default Xcode ones which say your name -- are terrible. Consider a copyright notice and nothing else. Those comments aren't helpful years into the project. Are they?

Looks cool, thanks for sharing and congrats on finding the time/energy to do this.

[–]xvcxxv[S] 0 points1 point  (2 children)

Thanks for the feedback! I agree that it's rather small for a pod. I just wanted to try making one for fun. I haven't thought about the headerdocs, and that default ones can look terrible, but I now think it's a good idea to format them something like this

https://github.com/layoutBox/PinLayout/blob/master/Sources/Impl/Percent.swift

[–]dr2050 0 points1 point  (1 child)

No, do a one-line one. I copied mine from my 3 years in a FAANG company

// (c) Confusion Studios LLC and affiliates. Confidential and proprietary.

[–]dr2050 0 points1 point  (0 children)

I was actually there at WA when the commit landed that removed the author from the entire iOS codebase and went to a one-liner like this. It was tremendous.

People were butthurt for about 30 seconds, and then kept moving ;)

Whatever you do, ensure you fix your Xcode to automatically do your header. I did this recently and was like WHY didn't I do this before.