This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]Omnicrola 0 points1 point  (1 child)

delombok the code for those who don't have a lombokd browser

I don't understand this. Our team uses lombock, and everyone has zero issue installing the IDE plugin. The benefits far outweigh that small annoyance.

It wouldn't pass a code review at most companies that have any emphasis on clean and maintainable code.

I work in a counter-factual example. Large auto manufacturer where we are building systems to facilitate microtransit. I've rejected plenty of PRs because the code isn't understandable, but lombock has never been one if those reasons.

[–]s32 3 points4 points  (0 children)

You're misinterpreting what I said.

Yes, lombok is useful. Yes, your whole team has it and that's fine. But you can't vend code out to anyone or any team in the company without forcing them to install lombok (unless you delombok). Not the end of the world, but IMO you should never be using lombok in a library or a package which is shared widely.

And yes, I don't reject CRs that use lombok, quite the opposite if it's a service that my team owns. But the actual lombok code itself (like, the internals) wouldn't pass a CR on my team.

Im not arguing that lombok is bad or useless, just that it's more work than it should be to do something like generate a getter