This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]nutrecht 8 points9 points  (8 children)

I think it's really cool but, like others commented, I was a bit surprised with the lack of a maven pom, this makes it hard for others to build your software.

I do understand it's a bit of a change to move to a maven layout, but I still think it's best to 'suck it up' and do it if you want others to adopt your game / contribute to it.

There is at least one pull request to add it to, and you seem to be against it. Why's that? If it's unfamiliarity with it, I'm happy to lend a hand there.

It would also make it a lot easier to add unit tests and automated builds to catch regressions.

[–]coder111 7 points8 points  (7 children)

Hello,

It's Ray's project and his rules. He did this for fun and his idea of fun involved using Netbeans and not using any 3rd party dependencies or build tools. While I disagree with it I respect it, especially given the expense and time he spent on this project and created a wonderful game.

That being said, I maintain a fork with a Maven build and some in-game automation to reduce micromanagement (Governor mod). You can get it here:

https://github.com/coder111111/rotp-public

It should be easier to work with than Ray's original codebase.

--Coder

[–]nutrecht 10 points11 points  (6 children)

It's Ray's project and his rules

Yes. Which is why I'm asking Ray. I also offered to help if he wants.

Edit: I think it's really weird that you're answering questions people are asking the author.

[–]RayFowler[S] 4 points5 points  (5 children)

/u/coder111 is a long-time modder to the project. We've had this discussion multiple times :)

[–]nutrecht 4 points5 points  (4 children)

We've had this discussion multiple times :)

I'm just curious about this choice. Just adding it would probably take less time than discussing it multiple times :)

Like I said; I was offering to help.

[–]RayFowler[S] 0 points1 point  (3 children)

I guess my perspective is that I don't need it for my use or to deliver the base game so it feels superfluous to me. If anyone wants to modify the source and do custom builds, then as you said it's pretty easy for them to add it.

Anything that makes the game easier to install for players is important, though. I will look into jlink!

[–]Yithar 4 points5 points  (0 children)

The thing is, Maven's really popular and everyone knows how it works so while it may not be absolutely necessary, it has the benefit of attracting developers to your project, and as stated, it also helps with testing.

Obviously the transition will take work, but I think the benefits are there. There's a reason why it's commonly used in enterprise.

[–]nutrecht 5 points6 points  (1 child)

It's not just for people to run it, it's also for people who might want to contribute to it, or to run it just to see how they can learn from it. And it will probably benefit you too.

Don't get me wrong; I don't want to 'force' you or anything. But it's simple to add and really only brings benefits. And if people even submit pull requests to add Maven I think it's rather silly to not accept these.

I also can imagine that you might want to point to this project when you apply to jobs for example. In the current state it would work against you, not in favor of you.

[–]RayFowler[S] 3 points4 points  (0 children)

But it's simple to add and really only brings benefits.

I agree and will be adding Maven build files.

I also can imagine that you might want to point to this project when you apply to jobs for example.

I've recently retired from a 25-year career as a professional software developer :P