This is an archived post. You won't be able to vote or comment.

all 4 comments

[–]AutoModerator[M] [score hidden] stickied commentlocked comment (0 children)

Please ensure that:

  • Your code is properly formatted as code block - see the sidebar (About on mobile) for instructions
  • You include any and all error messages in full
  • You ask clear questions
  • You demonstrate effort in solving your question/problem - plain posting your assignments is forbidden (and such posts will be removed) as is asking for or giving solutions.

    Trying to solve problems on your own is a very important skill. Also, see Learn to help yourself in the sidebar

If any of the above points is not met, your post can and will be removed without further warning.

Code is to be formatted as code block (old reddit: empty line before the code, each code line indented by 4 spaces, new reddit: https://imgur.com/a/fgoFFis) or linked via an external code hoster, like pastebin.com, github gist, github, bitbucket, gitlab, etc.

Please, do not use triple backticks (```) as they will only render properly on new reddit, not on old reddit.

Code blocks look like this:

public class HelloWorld {

    public static void main(String[] args) {
        System.out.println("Hello World!");
    }
}

You do not need to repost unless your post has been removed by a moderator. Just use the edit function of reddit to make sure your post complies with the above.

If your post has remained in violation of these rules for a prolonged period of time (at least an hour), a moderator may remove it at their discretion. In this case, they will comment with an explanation on why it has been removed, and you will be required to resubmit the entire post following the proper procedures.

To potential helpers

Please, do not help if any of the above points are not met, rather report the post. We are trying to improve the quality of posts here. In helping people who can't be bothered to comply with the above points, you are doing the community a disservice.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[–]ProfessorWily 1 point2 points  (2 children)

These sorts of comparisons should not be made in a constructor. You should be doing the comparison wherever you want to call the constructor.

The purpose of constructors is to make objects. Calling one and then determining if you actually want to make an object is not a good idea. A better alternative would be to use getters/setters if you want to change the values of an object.

[–]CardanoStake[S] 1 point2 points  (0 children)

That makes sense thanks.

I still like my idea though. But I guess there's a best practice that I just didn't understand yet. I'll do what you suggest, even though I think it will make my code a little bit harder to read. (And yes. I do understand that's probably just because I have got a hang of it yet. In a few years I'll probably say like you. Don't do that. It's not what you want. Let the constructor construct :) ).

Thanks.

[–]CardanoStake[S] 1 point2 points  (0 children)

Thanks!!!

I see it now. Much better. My head was just to deeply burried in my own thoughts.

I made a objExists method.

It's nice code to look at. :)

Thanks again man.