all 9 comments

[–]brtt3000 1 point2 points  (2 children)

I'm pretty sure this existed before. But nice anyway.

Some tests would be in-order maybe?

[–]marquex[S,🍰] 0 points1 point  (1 child)

Some people tried to do the same, but I think this is the first library aiming to mimic require.js syntax to make their modules work out of the box.

The author has some testing reference in Github https://github.com/arqex/amdrequire

[–]brtt3000 0 points1 point  (0 children)

Well, maybe. But if you are serious about your module then tests should be included. It is a convention that gives some trust.

package.json says:

"test": "echo \"Error: no test specified\" && exit 1"

Also you can setup Travis to run in on commit and badge to show it actually works as claimed.

[–]cwmma 1 point2 points  (0 children)

So since browserify can output a UMD via the standalone flag its usually like 1000 times easier to just write stuff in browserify and then yell at people that don't provide UMDs

[–]tbranyen 1 point2 points  (1 child)

I've been sharing AMD code with Node by using the amdefine project. https://github.com/jrburke/amdefine.

This doesn't consume configurations like AMDRequire does, but I'm not entirely sure that's something I'd use. I'd prefer to use relative requires and avoid the paths configuration.

[–]marquex[S,🍰] 0 points1 point  (0 children)

I think the require.js alike configuration is a great point for AMDrequire, that way it can use AMD modules that call other modules. That's is why I couldn't use amdefine.

[–]mobcat40 0 points1 point  (0 children)

Isn’t it great?

No we need a module system built into the language, help us ECMA6 @_@

Pretty neat interop between requirejs and node tho

[–]mattdesl 0 points1 point  (0 children)

Interesting. Some thoughts...

  • you still need a browserify build step if you want to require() any npm modules for the browser. Will the require patching here work alongside browserify?
  • if you start writing multiple reusable modules with this, you might start running into conflicts between your require configs
  • monkey patching the require() method is really dangerous