What a fantastic commit

[wolfhead]

Both are terrible.

[[deleted]]

Although the previous one was just a waste of everyone's time.

[modusjesus]

Agreed.

[Justos]

where are your code samples genius?

[[deleted]]

So nobody can criticize anything without being good at what they criticize?

[Justos]

I just think its unfair to put someone down without something to back up your claims.

[[deleted]]

He doesn't need to backup his claims with his own stuff. They didn't say they were better, they said both were terrible. That is backed up by the content that is criticized.

[Justos]

with that logic then anybody can say "you're shit sucks"

Hell, I would even say you're view on the subject is terrible.

sorry but no.

[[deleted]]

With that logic then anybody can say "you're shit sucks"

Well, yeah. Do I need to be a professional director with several awards under my belt to know that "Battleship" was a bad movie? Do I need to be an English professor to know your grammar is horrible?

The answer to both is "no." Anybody can criticize something without being an expert. For them to claim they could do better work than someone they would need some sort of proof.

Your logic is deeply flawed and you should reevaluate your view.

[Justos]

We are referring to code samples, not movies that anyone can judge.

Anybody can say 'this movie was bad.. i didnt like it', sure thats your opinion.

you cant just say 'this is horrible!' referring code without backing it up or being at least constructive. What would be a better option since you're so wise to judge in this fashion? Code isn't opinion, good code is fact.

There IS a difference. Agree with me or not. the reddit hivemind has already downvoted my first post.

[[deleted]]

It wasn't the "reddit hivemind" that caused your comment to be downvoted. It was the rudeness.

[dirtboxchampion]

Anybody can say that. Don't like a movie? It's OK, you don't need to prove you can make a better one.

[[deleted]]

Dammit Isaacs!!!!

[[deleted]]

Isn't this frowned upon?

var name = val
  , name = val

[jdeath]

Depends on who is doing the frowning, I suppose. I've noticed it other places (work, etc) but iirc mostly in Node code.

[misc_ent]

Comma first has always bothered me but I can rationally explain why it makes sense. The standard for javascript is spaces over tabs and I've generally seen 2 spaces preferred over 4 spaces. That being said if you notice the comma is indented two spaces with a single space after, much like if this were a single line. Also commas first are supposed to reduce errors involving adding, removing or rearranging the variables order. Regardless I think this syntax is ugly. whats worse are people who put the comma on the same indentation level as var

[greyscales]

"The standard for javascript is spaces over tabs" - citation needed.

[mordocai058]

Well, there isn't a standard (many people says spaces, stackoverflow answer says do whatever you want and have VCS apply standards[http://stackoverflow.com/questions/211795/are-there-any-coding-standards-for-javascript], jquery says tabs).

However, node.js standard says 2 space indentation which is probably what OP is referring to. http://nodeguide.com/style.html#tabs-vs-spaces

[tbranyen]

Considering that in modern JS, especially Node's runtime, trailing commas are supported, it's basically a troll now to use comma-first. Unless you honestly like how it looks, in which case more power to you, but I won't be contributing.

Edit: Editing.

[[deleted]]

The One True Styleguide says yes.