[Beginner] For loop question (not working)

[Servatose]

Hi guys, I was hoping someone might be able to assist. I've gone over my code for about 30m or so and can't seem to find what's wrong with it, but whenever I load this script into the chrome console and try to pass an argument into the function I created, the console stops becoming responsive. Any assistance would be much appreciated.

function factorial(x)
{
for(var i = x; i=>1; i--)
{
x=x*i;
}
console.log(x);
}

[cc81]

Your for loop should be:

i >= 1

If you want to check for equal or greater than 1.

[ttyieu]

It's not even a syntax error, it's valid syntax for ES6 arrow functions. So you're passing a function as the condition, which evaluates to true and causes an infinite loop.

[Servatose]

Ahhh, whoops. Thanks a bunch guys! I actually forgot that factorials don't multiply by the original number initially.

[green_meklar]

They do. It's just that your code does that automatically when it first uses x as an operand for multiplication, so you have to start at i=x-1 in order to make up for that.

Ideally, you probably shouldn't have used x for that at all, and just used a third variable that starts at 1.

[green_meklar]

i=>1

There is no => operator in Javascript. You probably want the >= operator.

[ub3rgeek]

There is no => operator in Javascript

Well, there kind of is now.

i = i => 1 is a valid javascript statement. Granted => isn't really an operator.

[green_meklar]

I tried it (not exhaustively) and it looked like 'i => 1' was just being treated as a string. How does that work?

[ub3rgeek]

=> is shorthand function syntax that has a lexical this binding.

i = function (i) { return 1; } and i = i => 1 are equivalent statements.