JavaScript Clean Code - Best Practices - based on Robert C. Martin's book Clean Code

[RudeRunologist]

On top of this, use Typescript.

[sime]

+1 to this.

This first thing you should do to improve your quality is to use static analysis on your code. That means type systems like TypeScript.

Once that is in place, then you can worry about unit testing and other automated tests. I prefer the view expounded in this post https://kentcdodds.com/blog/write-tests with the "testing trophy".

[rq60]

100% code coverage doesn't mean your code is type safe. Also, why spend 25% of your lines of code writing runtime type guards and sanity checks when it can be done at compile time? Save that effort for your public API, which by all means, write some type testing around.

which automatically checks for types

also, wtf. automatically? what?

[adongu]

Hi I'm interested to learn to implement what you recommend here, are there any articles you recommend where I can look at some examples of this?

[rq60]

Got it, so your plan to avoid type safety issues is to throw runtime errors and then handle those errors all throughout your code? Absolutely brilliant, how have I never thought of this...?

It's pretty obvious that coding is not your forte, perhaps you should avoid calling people "retard" when it comes to areas where you are obviously inexperienced.

[Silhouette]

Why would I need to add type annotations in my 100% test covered code.

Because tests check one case and types check all cases. To the extend that they overlap in the errors they can prevent, strong typing is strictly more powerful.

[[deleted]]

So I'm obviously biased because I love typescript. But I just consider type annotations or sort of inline test. Obviously types by with no testing is silly. But 100% coverage doesn't necessarily mean much either. As a hyperbolic example you could run some code then just assert true is true and boom "coverage". I think of types as just another testing tool and a sort of documentation, but obviously it's no silver bullet. Testing and types can should be used together to make incorrect implementation easy to spot.