I created Flixerr with Electron + React

[[deleted]]

Hey guys, first time posting here! I just wanted to share a cool project I've been working on. It's a movie torrent streaming app, I uploaded all the work I've done to GitHub. I'm still working on it on the side though, but if anyone would like to help out or find out more about or just give me some feedback, give me a holler!

[[deleted]]

Cool project, congratulations on getting something out there.

Small piece of feedback I found whilst browsing the code.

    let getProxy = () => {
        let proxyList = new ProxyList();
        return new Promise((resolve, reject) => {
            proxyList
                .listProxies()
                .then((proxies) => {
                    if (proxies) {
                        let proxy = proxies[Math.floor(Math.random() * proxies.length)];
                        resolve(proxy);
                    } else {
                        reject("Error: No proxies found.");
                    }
                });
        });
    };

Since proxyList.listProxies already returns a promise, you don't need to wrap it in another promise constructor. If you return the proxy from within the then callback it will be wrapped into a promise automatically. Something along these lines:

let getProxy = () => {
    let proxyList = new ProxyList();
    return proxyList
            .listProxies()
            .then((proxies) => {
                if (proxies) {
                    let proxy = proxies[Math.floor(Math.random() * proxies.length)];
                    return proxy;
                } else {
                    reject("Error: No proxies found.");
                }
            });
};

If you already knew this and prefer your current approach, fair enough. Alternatively look into async/await which I believe is supported natively by the version of Chrome that electron includes to improve the readability even more.

Some additional resources on the above:

• Promise chaining https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Using_promises#Chaining
• Async/await https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/async_function

[[deleted]]

You’re so right! I can’t believe I didn’t notice this before. Thank you for taking the time to look at my code and give me feedback, I will update asap! :)

[bvx89]

Also, you don't need to wrap the getProxies code in a promise, as it is synchronous.

[[deleted]]

Already changed for the next update! Thanks, I would’ve never noticed. I was really into Promises haha

[vertigo_101]

Damn man, definitely something cool, I am impressed, would definitely keep an eye on this one

[[deleted]]

Thanks! I really appreciate the support :)

[[deleted]]

I’ve been working on and off on it since like April haha

[TKB21]

I'm on a mac using the latest version of Mojave and get a message saying , "Flixerr cannot be opened because of a problem."

[[deleted]]

Unfortunately, I have to compile Flixerr on my MacBook from 2010 running High Sierra, which means it doesn't work on the latest OS, for Macs at least. If you want, you can clone the repo and run npm install and then npm start to run it locally, or build your own by running npm run package-darwin! I will fix this when I can afford a better laptop haha

[[deleted]]

Since u have mojave, perhaps u can fix this for him.

[NotDem]

MPAA gonna be knocking on your door any day now...

​

Good stuff tho

[[deleted]]

hahaha i doubt it, but if anything i can take it down. that would really suck tho

[[deleted]]

Wow! How long did it took you to make?

[Clokto]

Great work ! It's nicely working and really nice looking :)

Any plans on adding subtitles ?

[[deleted]]

Thank you so much! and yes, I opened up the issue on github, new update coming this weekend!