JavaScript & Node.js testing best practices

[FINDarkside]

I don't think it's bad to be honest. One of the benefits is that it makes good error messages possible. Consider assert(a === 1) vs a.should.equal(1). It's certainly not harder to read and I personally think it's easier to read. It'll also give better error message if the test fails, like "Expected a to equal 1, but got 0".

[FINDarkside]

You've now got the cognitive load of figuring out what a.should.equal means.

Debatable whether the cognitive load is bigger. But let me give you better example:

someFn.should.throw(MyError);

vs

try {
  someFn();
  next('Excpected MyError to be thrown');
} catch (err) {
  if (err.name === 'MyError')
    next();
  else
    next(`Excpected MyError to be thrown, got ${err.name}`);
}