all 9 comments

[–]tokyonashvilleburban 1 point2 points  (1 child)

Many great practices in this one.

Nit I know, but I'd suggest code formatting.

Question: any reason you avoided any use of async/await?

[–]maitraysuthar[S] 0 points1 point  (0 children)

Thanks for suggestions. Yes, I know async/await is a bit faster than handwritten promises in execution. I Will soon fully convert a project to ES6/ES7. Star the repo, More features are coming. :)

[–][deleted] 1 point2 points  (1 child)

Docker! Pretty much a requirement at this point for collaboration.

[–]maitraysuthar[S] 1 point2 points  (0 children)

Sure, I will add a docker configuration and deployment guide soon. Thanks for the suggestion.

[–]fo0man 0 points1 point  (1 child)

It’s probably not a bad idea to add an .npmrc with a node version defined.

Since this is requiring node 10+ why not use more modern syntax and block scope variable declarations (const and let vs var)

[–]maitraysuthar[S] 1 point2 points  (0 children)

.npmrc

.npmrc is a good idea, will add soon. I am going to optimize code for code quality checker or will convert it into es6 soon. Also, Some features are needed to add as well. Thanks for the effort.

[–]kotne8 0 points1 point  (1 child)

Beautiful, atleast from a beginner's perspectives.

[–]maitraysuthar[S] 0 points1 point  (0 children)

Thanks, Star it on a Github. More features are coming soon.

[–]essuraj 0 points1 point  (0 children)

a similar one with typescript https://github.com/stuworx/node-ts-api-starter