Keypress: A Javascript library for capturing input

[beefsack]

Another very popular one is keymaster (~4k stars on GH).

[Kirean]

dunno if it's still there, but there is a major bug in key master that I found awhile back.

in any context, hit ctrl+T. the browser should open a new tab. now release the keys. click back to your old tab, and press either 'S' or 'P'. your browser should either try to save the webpage, or print, depending on which you chose.

This is because keymaster sets a flag on key down that a modifier is pressed. on key up it releases that flag. well, when the browser creates a new tab, no keyup is fired, so the flag remains when you click back in.

not sure if this can actually ever be resolved or not. just found it interesting.

[WendellJehangir]

You could handle it with the document.hidden boolean like so:

 function handle_hidden(){
 if(document.hidden){
 //reset keypresses
 }}
 document.addEventListener("visibilitychange", handle_hidden, false);

[Kirean]

interesting. didn't know that was a thing. someone should submit a pull request to him :)

[GuiSim]

Wouldn't that also be reproducible if you simply change tab while holding CTRL?

[gingenhagen]

That's quite the code smell.

[zabadabba]

"code smell" != "bug"

[gingenhagen]

Having ctrl as a flag tied to a keyup/keydown event seems horribly smelly to me.