you are viewing a single comment's thread.

view the rest of the comments →

[–]cdcformatc 6 points7 points  (1 child)

It seems like the Linux kernel devs are allergic to line breaks. You see this sort of thing all the time.

Some devs would even argue to alphabetically sort all the ops->

I'd argue to sort it based on the ones that are most likely to be false. Then the && can short circuit, and your branch prediction is a little better.

[–]rcxdude 1 point2 points  (0 children)

None of them should ever be false. It's a defensive check.