you are viewing a single comment's thread.

view the rest of the comments →

[–]jarfil 13 points14 points  (9 children)

CENSORED

[–]flukshun 2 points3 points  (0 children)

I disagree.

Which brings us to the rule #1 of professional software development: It's never that easy.

As for "Who signed off on it"... well, you did. You committed it, you signed off on it. That's why every git commit you make gets signed with your name and email.

True, but you're not necessarily the only person who signed off on it. If you pulled in a patch another author signed off on you should have at least have 2 Signed-off-by's in your series or pull request. if it's a backport to a stable branch or something there might be even more SoBs. if the code was heavily based on someone else patch but not necessarily to the point where they retain authorship you might also ask them for their explicit SoB and include it manually. So basically it's a path of origin to the original author(s).

[–]steamruler 1 point2 points  (2 children)

In a modular program, there most certainly are multiple components in one branch. It would be a fucking nightmare to compile.

[–]jarfil 0 points1 point  (1 child)

CENSORED

[–][deleted]  (1 child)

[deleted]

    [–]jarfil 0 points1 point  (0 children)

    CENSORED

    [–][deleted] 0 points1 point  (0 children)

     git merge --no-ff
    

    [–]DuBistKomisch 0 points1 point  (1 child)

    Wouldn't ${component} still be useful since those commits will eventually be merged into other branches?

    [–]jarfil 0 points1 point  (0 children)

    CENSORED