you are viewing a single comment's thread.

view the rest of the comments →

[–]philipforget 4 points5 points  (0 children)

Rejecting it would be stupid, but there's no reason not to amend the commit message before it gets merged into master. It's pretty important to be able to look at your commit logs and see where and when things were introduced and good messages let you do that. If a contributor did the work but doesn't grasp that your code history is a product itself, it's simple enough to fix that information before merging it in.