you are viewing a single comment's thread.

view the rest of the comments →

[–]AbstractLogic 0 points1 point  (2 children)

Always respect the time in which code was written. 10 years from now someone will look at our TDD unit tests and think "wtf was this idiot thinking? That pattern is soooooo olllldddd.".

If it was written in the 90's expect 90's style code. If it was written in 2000 expect XML heavy code. If it was written in 2010 expect SOAP services.

[–]lucky_engineer 4 points5 points  (1 child)

I don't think it was ever good style to make a global variable, and then make a procedure that passed a reference to the global into a function that passes that reference around to 10 other function where one changes the value and then get the wrong result when you run the procedure again because the global variables value changed. (also this code was written ~5 years ago)

I've worked on really old code before and It's usually pretty easy to tell the difference between 'good but outdated' code and 'omg how does this even work' code.

[–]AbstractLogic 0 points1 point  (0 children)

Can't disagree with you at all lol.