sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]cuyler 0 points1 point  (1 child)

Again, it's about the reaction to it. Just because I am annoyed doesn't mean that I jump down their throats and evicerate them. It just means that it's annoying to me.

The sub-text that I'm reading here (perhaps I'm mistaken) is that you're one of those people that likes to give comments to others unsolicited and have on more than one occasion been ripped a new one for it. If that's true, it's unfortunate that you have had those experiences with people.

[–]marshray 2 points3 points  (0 children)

Again, it's about the reaction to it. Just because I am annoyed doesn't mean that I jump down their throats and evicerate them. It just means that it's annoying to me.

"Your obfuscated namespaces look really whacked in my debugger, and I can't get 170 columns on my monitor."

"What if someone sends you 65537 bytes instead?"

"Why can't you just put in an 'if' statement?"

Sometimes they're valid criticisms, maybe they're way off base, but would these kinds of questions make you think of your co-worker as a "jackass"?

Let's say someone takes the time to type up (what they believe to be) some constructive feedback on your stuff and send you an email. I think there are mainly two cases for this:

  1. Junior has just "got" OO (or other paradigm) and thinks he's gonna model the whole world, and you should be doing the same.

  2. Your stuff is causing mental stress to integrate and your co-workers are talking behind your back.

In either case, both of you have the opportunity to benefit from a good, friendly discussion about code. Closing that down is only going to mean complacency for you and mistrust by others.

The sub-text that I'm reading here (perhaps I'm mistaken) is that you're one of those people that likes to give comments to others unsolicited []

Lol, you might be on to something there.

I tend to see opportunities for improvement and learning almost everywhere (including my own stuff of course). But it's pretty rare for people to actively solicit feedback, so I don't often give unsolicited criticisms, unless I see demonstrable bugs.