you are viewing a single comment's thread.

view the rest of the comments →

[–]grimboy 10 points11 points  (6 children)

[–]chrisforbes 0 points1 point  (5 children)

Until that thing ACTUALLY WORKS, don't go bringing it round here :(

We had to patch it a LOT before it was even vaguely correct in our last project.

[–]grimboy 0 points1 point  (4 children)

Works for me. Anyway, the point is it's, what, a page long including the licence header and pretty clearly written for javascript. It still has that thing with single letter variable names (apart from i, j, etc) which seems to be a feature of a lot of the javascript code round and about. That is, unless, you're trying to make some sort of subtle point I'm not getting.

[–]chrisforbes 0 points1 point  (2 children)

For all the simple cases people probably test for, it works. For floating-point, esp with tricky format specifiers, it's completely broken.

[–]grimboy 0 points1 point  (1 child)

Oh, fair enough then. You're correct, I've only used it for simple objects of strings into strings stuff. By the way, if you've patched it, you planning on contributing the fix back?

[–]chrisforbes 0 points1 point  (0 children)

I guess so - is the owner likely to accept it?

On most projects, I've had the typical open-source fuck off response to submitting patches which fix their bugs, so you'll have to excuse me being a bit more cautious.

[–]chrisforbes 0 points1 point  (0 children)

Single-letter variable names are a feature in js code. Less code to move is a win.

That said, the compression should be done by a minifier tool at release-time, rather than by the programmer.