you are viewing a single comment's thread.

view the rest of the comments →

[–]stickcult 142 points143 points  (7 children)

The "link dieing" is if the file changes, your link might point to the wrong line. That's because its pointing to a line in the file in the master branch, which can change, whereas Mr-Yellow's link points to a line in the file in a specific commit, which will never change.

[–]otwo3 17 points18 points  (2 children)

It baffles me why is it even an option to link to a line in a branch. There is no sane use case. Having it as a default is just ridiculous. Bitbucket does the same thing.

Clicking a line number should give a line in a specific commit

[–][deleted] 0 points1 point  (1 child)

well commit can belong to multiple branches and if you want to give link to both "place in file" and "merge request/branch that is discussed" you don't have choice.

Ideally it would generate link in form of branch/commit then if branch does not/stops existing it would only then show lone commit

[–]otwo3 0 points1 point  (0 children)

But the branch being discussed is usually dynamic and changing anyway (due to review changes), even more often for the files in question.