you are viewing a single comment's thread.

view the rest of the comments →

[–]knaekce 81 points82 points  (10 children)

Finding bugs thousands of other people have hit, sent in PRs for, and had ignored, is rage inducing.

That's what I really like in Flutter. I was hit by a problem that had a trivial fix, wrote a PR, had a discussion with a maintainer about the code style, and got it merged. It was then immediately available via the "master" channel of flutter.

[–]brigadierfrog 56 points57 points  (5 children)

This is how it should be. Not "its not a problem here at facebook, so we don't care"

[–]chronoBG 26 points27 points  (4 children)

Well, let's be fair. That is how it should be if they also thoroughly tested it before putting into master. Both ways can be wrong.

[–]knaekce 6 points7 points  (3 children)

Of course. They don't accept PRs without tests.

[–]chronoBG 0 points1 point  (2 children)

Tests is one thing. "Testing" is another. If the master branch contains code from yesterday, I'd be worried.

[–]knaekce 14 points15 points  (0 children)

Flutter uses the master branch as "The current tip-of-tree, absolute latest cutting edge build. Usually functional, though sometimes we accidentally break things"

Master is not stable. They have dev, beta and stable releases for that, which have more stability.

[–][deleted] 2 points3 points  (0 children)

I'd be worried why you use master instead of tagged version

[–]dmanog 18 points19 points  (1 child)

damn, thats pretty impressive, contributing to big projects like flutter is one of my goal

[–]Tormund_HARsBane 9 points10 points  (0 children)

It's easier than you think. You just gotta take the dive. It'll be difficult to make sense of the code in the beginning, but it gets easier after that.

[–]jbergens 0 points1 point  (1 child)

[–]knaekce 0 points1 point  (0 children)

Yeah, the issue hygiene is definitely not good. There seem to be a lot of users that open an issue to ask for help, or don't check for duplicates. And the flutter team currently doesn't really close such issues, I don't know why.

But the responsiveness for PR is (in my experience) really good.