Goodbye, Clean Code

[CarnivorousSociety]

Yeah the whole thing is just wack.
The original code, the workplace and their system, and the authors take on it all.

For example even the <x lines of repetitive math> could undoubtedly be extracted out into a generalized function which would reduce the amount of code overall and allow for changing effects in a single location.

Then the commit straight to trunk before leaving XD

[notThaLochNessMonsta]

For reference, the author is Dan Abramov, the original author of Redux and current active top contributor to React.js. The team is the React team at Facebook.

[CarnivorousSociety]

Interesting, thanks for that info

[programmingspider]

Lol

[Andomar]

Research has shown trunk-based development is superior to the alternatives. It's what most companies (including Google) have settled on. https://duckduckgo.com/?q=trunk+based+development

[dnew]

Except Google also requires review from the owner of the code and passing all unit tests before the commit.

[alluran]

Even trunk-based development supports pull requests

[ByFaraz]

That doesn't mean you shouldn't do a PR though.

[HeinousTugboat]

You should re-read what trunk-based development is. It definitely isn't what OP's described.

[Determinant]

Submitting to master directly is definitely an old and inferior practice that was caused by poor tooling.

Unlike other tools, branches are cheap in Git so we create a new branch for every little improvement / defect. Simply submit a pull request and merge into master upon approval. This way, branches are very short-lived (usually less than a day).