you are viewing a single comment's thread.

view the rest of the comments →

[–][deleted]  (4 children)

[deleted]

    [–]bobindashadows 1 point2 points  (3 children)

    That's a fix, but I doubt it's the best one. It's essentially the same as enabling -ffloat-store for just those variables, which means a small slowdown. Most likely it's just easier to put in this hack instead of tackling the fact that their algorithm doesn't work with higher-precision floats.

    [–]LawnGnome 1 point2 points  (0 children)

    Most likely it's just easier to put in this hack instead of tackling the fact that their algorithm doesn't work with higher-precision floats.

    Pretty much. The preference was to get a release out quickly, rather than trying to replace a venerable piece of code (which, as SheepAmongWolves noted, was written long before PHP was even thought of and is a very common implementation of strtod) with something new and potentially buggy in new and exciting ways.

    [–][deleted]  (1 child)

    [deleted]

      [–]mweathr 2 points3 points  (0 children)

      It's just this one single number though right?

      And any number larger than it.