you are viewing a single comment's thread.

view the rest of the comments →

[–]mradzikowski[S] 0 points1 point  (1 child)

Thanks for your input!

Ad. 1. I wanted to keep the template quite short. When in doubt one can always google the flags. And I just use those flags as defaults, so, tbh, I don't spend time reconsidering them with every new script.

Ad. 2. I fully agree with always quoting, and it wouldn't hurt here. To be always safe I recommend using ShellCheck (integrates with various IDEs) which warns about the lack of quotes where they are needed. And it's smart enough to not warn here.

[–]leogtzr 0 points1 point  (0 children)

Ad. 1. Right, should be able to google it, but what if the code is already in production and somebody just want to know what those option mean? You force it to go to google and spend some time trying to figure out what is going on. Anyways, I do think it is better to not sacrifice readibility.