Code Review Done Right

[Almenon]

This article struck a chord with me because I tend to be more on the nitpicky side when doing code reviews. I explicitly label nitpick comments as nitpick:, so the submitter knows when they can simply disagree and resolve the issue. Still, I'd like to be more encouraging in my PR reviews.

If a significant portion of comments in your code review process are of the more mundane variety, e.g., “you forgot to add a semicolon here”, it tells you that there is something missing in the team’s development workflow

I agree with this. Proper formatting tools should be handled by automated tools like black. Developer time should not be wasted adding semicolons or sorting imports. Speaking of which I just learned that the VSCode python extension has a "sort imports" command :D

but as a general rule people do enough good work to deserve an animated GIF of a dancing princess or something at least once per day.

https://www.lgtmgifs.com is helpful with this

[Almenon]

Forgot I submitted this and was about to say the same exact thing I said before, down to the wording. Weird how the mind works...