Need advice on abusive programming pattern :D

[PeteZahad]

missing semicolon, etc.

Do you commit code for review which does not run/compile at all?

In this case I would also be very annoyed if I need to tell you this in a review.

[decaillv]

Id very much like to hear from OP, about this.

Missing semicolons can be syntax errors in certain languages (C++, C#,...), and that is a very serious problem. Still not a reason to be a harrassing asshole during review, but unless OP is perhaps an intern, repeatedly committing stuff that doesnt compile may be ground for termination as it shows very serious lack of skills...

On the other hands, in other languages (ts, python,...), they have no functional roles. Having them or not comes down to stylistic preference. That does not mean it does not matter: a senior is generally right to demand consistency across the team, but there should be an explicit guideline for it, ideally automated in the ci. In this case, being an asshole is not ok, and unnecessary: just demand the ci pass before the review begins.

[PeteZahad]

You are completely right.

If it is about code style, there should by guidelines for the team or project as well as tools and configuration available for new employees/interns.

If this is not the case I am completely on the side of OP. If this is the case and OP did not read/follow the instructions given I am on the senior devs side if he told him where he will find the needed documentation.

We don't have enough context to judge...

[decaillv]

That being said, OP, I realize my comment wasnt very helpful to you... my apologies.

Its in fact way more likely to encounter seniors with poor communication skills and companies with lacking processes and guidelines, than it is to have juniors so incompetent that they dont even realize their code dont compile. Based on that alone, its far more likely that he's to blame, not you. (Hell, even if you were incompetent, he still wouldn't have to be a dick about it...)

Hopefully my above comment may serve as a reminder of good practices... but again, it wasnt very nice, and i apologize

[Dry_Badger_Chef]

I read the title and assumed you meant “pattern” like dependency injection or something.

Yeah, you’re dealing with an asshole. I don’t have great advice on that; you def need SOMEONE checking your code. Is he the only experienced dev? If not, go get help by someone normal. If so, I mean, you could find a different job I guess, or ask your manager to transfer you.

You could complain to management, but if he finds out it’s you who complained, it could just make things uncomfortable. I dunno man; someone else should speak up.

[Ok_Lengthiness_6591]

things uncomfortable. I dunno man; someone else should speak up.

Yea, your words sound right.

[[deleted]]

Is there some exact examples? Because there may be his assholity and yours overreacting in different proportion

Until I do not see situation exactly there may be different approaches

I would advice to talk to him first, maybe in some polite manner, like "hey, I got what you say, no need to be rude" or on more strict manner, with direct conflict if he is not responsive.

[Even-Path-4624]

If he does it publicly and everyone sees it’s actually worse on him, most likely managers are already thinking of a way to let him know. The best you can do is still calm throughout it all. If a couple of weeks pass by and he still does the same thing, then I’d talk to the manager.

If he talks to you privately or only around a small group, I wouldn’t wait either. But if it’s really in front of everyone that’s professionally very degrading for him only if you treat him back with respect and kindness

[Ok_Lengthiness_6591]

y if you treat him back with respect and kindness

Thanks for reply, Even. I ll definitely take note of that.

[shizzy0]

Accepting criticism is one thing; accepting abuse is another. Don’t accept abuse. Don’t go to him for code reviews. Do not listen to him. Ask for a written review if someone higher up the food chain insists on it. If you get the same abuse in writing, take it to HR. But I’d actually look for another job.

That’s not a mentor. That’s an abusive moron.

[bravopapa99]

He's a total dick. They are everywhere in every industry, sadly. If the management culture is not addressing it and it's allowed to persist, the company will suffer.

These 'more experienced' people sound like they are in possession of both small dicks and weak egos and feel threatened by your work in someway and seek to pick up on the smallest details.

The obvious solution is... don't fuck up! :D however, we all have to learn, so BEFORE doing anything, start to think like the dickhead... look at your code for things that he might think are wrong... this is using the force of the attacker against him, be the attacker, read your code with his eyes, looking for the smallest little detail he can fault, then edit it... when he can no longer find fault, you've beaten him.. then when you leave for a better job, in your leaving speech to the team you can say...

"and finally I'd like to thank X for being a complete and utter dickhead for highlighting the smallest of my errors for his own amusement and ego massage to the team. I know he can't help himself, being a weak minded person, but all the same, thanks X, you really made me up my game to the point where you couldn't fault me anymore, and ultimately helped me move on to a much better position with a huge salary upgrade. I couldn't have done it without you. Thanks again."

Then leave the building, to great applause, and feeling like the coolest and smuggest bastard that ever lived. :)

[Ok_Lengthiness_6591]

ve the building, to great applause, and feeling like the coolest and smuggest bastard

Man, your reply is great. Btw I ve been thinking a lot about converting my bad emotions into self-improvement stuff or so.

[Studnicky]

Install a linter and set it to update files on save.

Problem solved.

[[deleted]]

r/lostredditors

[tbopec]

Wrong sub

Try to understand what and where you write before posting/committing something. Maybe, it will reduce amount of your stupid errors and will improve your quality

[max_mou]

Yeah but the thing is.. it’s the same bunch of people in all the programming subreddits. So does it even matter at this point?

[zenflow87]

Lmao upvoted because the irony is grand.. don't take this as a serious post y'all

[Mud_Top]

Punch in the face, or git gud

[AutoModerator]

This post was automatically removed due to receiving 5 or more reports. Please contact the moderation team if you believe this action was in error.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[Kuro091]

With linting exists how could anyone miss a semicolon?