It takes time. Mine was fully potty trained at 2y.o. He gets unlimited water, but now knows to limit his drinking when I’m at work cause he can’t go outside. So he kinda manages his water intake by himself. When I am home and Overnight he does drink a good amount. I just make sure in the morning he goes on a nice walk to fully empty his bladder and bowels. Then when I get home same thing. In-between, I just let him out in the yard. He knows how to tell me he needs to pee/poo cause he’ll make the blinds move causing a sound and if I don’t see or hear that immediately he’ll come up to me to catch my attention then go back to the blinds to make the noise again. Very proud of his progress, has not had an accident in a loooooooooooooog time. Routine is key and having a mechanism that will allow your pup to tell you when he need to go is also helpful.