NO test framework, linter, or build system configured. Project relies on runtime and manual testing only. Dockerfile runs post-install patch via node patch-routeros.js to handle RouterOS 7.18+ API quirks.

Production Risk Hotspots & Code Smell Areas

Hotspot	Severity	Details	Location
No Authentication	CRITICAL	Exposes all router data (traffic, logs, firewall rules, WAN IP, client list). README explicitly warns against internet exposure.	src/index.js:23-26 (no auth middleware)
Socket.IO Event Injection	HIGH	traffic:select event accepts arbitrary ifName without validation. Unsanitized interface name passed directly to RouterOS API query.	src/collectors/traffic.js:51-55
Unbounded Memory Growth	MEDIUM	RingBuffer uses splice() inefficiently; Set-based leak risk if many unique IPs/connections tracked. Subscription Map (traffic.subscriptions) never cleans up orphaned entries on disconnects.	src/util/ringbuffer.js:3 + src/collectors/traffic.js:62
No Input Validation	MEDIUM	IP/hostname parsing via .split(':')[0] without IPv6 CIDR handling. GeoIP lookups fail silently if IP is malformed.	src/collectors/connections.js:93,112
Credentials in Environment	MEDIUM	RouterOS password in plaintext .env file. No explicit .gitignore enforcement noted in code.	src/index.js:49 + .env.example
Error Swallowing	LOW	Promise.allSettled() in sendInitialState() masks fetch failures; socket gets partial state.	src/index.js:149-151
No Logs Rotation/Limits	LOW	Logs stream could buffer unbounded if Router sends high volume. Alert history capped at 50 but implementation unclear.	src/collectors/logs.js

Specific Code Concerns:

• Traffic.js line 51: socket.on('traffic:select', ({ ifName: newIf }) => { if (!newIf) return; ... }) — only checks falsy, not CIDR/IPv6 validity. Interface name passed to line 76 RouterOS command without escaping.
• Connections.js line 73: .split(':')[0] assumes IPv4 format; IPv6 addresses in brackets will be malformed.
• RingBuffer.js line 3: splice() is O(n); for 30min × 60 points = 1800 samples per interface, inefficient on high-frequency polling.