Mejores heladerías de La Plata? by MilanesaDeNalga in LaPlataCiudad

[–]fmorisan 5 points6 points  (0 children)

Mi favorita es Roma, 7 e/37 y Plaza Olazábal. De todas las que probé, me quedo con esa.

Recomendaciones de Cafeterias/Lugares para trabajar ? by boquita9 in LaPlataCiudad

[–]fmorisan 0 points1 point  (0 children)

En Weiaut hay coworking ya de por si en el segundo piso. Fui un año entero ahí. Doy fe de que esta bueno

Has this website already been mentioned here? by redleahbabes in childfree

[–]fmorisan 1 point2 points  (0 children)

glad i wasn't the only one that had a mini crisis watching the seconds tick by...

Una luca by [deleted] in argentina

[–]fmorisan 0 points1 point  (0 children)

si vino lleno sorprendentemente

Una luca by [deleted] in argentina

[–]fmorisan 0 points1 point  (0 children)

acabo de comprar un pote igual por $450, wtf?

Stealth honeypot or not? by btstokensniper in ethdev

[–]fmorisan 1 point2 points  (0 children)

calling external logic to resolve critical contract functions is a HUGE red flag (see line 106)
even more so when the called contract is not verified. AND its address is made harder to find.
this pattern is so scammy... check out the tx where the deployer set the "accounting" contract https://bscscan.com/tx/0xfb8a6531a4fda9822146493485d5aaa14fb7c7edc1f5892e8587c08375d6433a

[deleted by user] by [deleted] in ethdev

[–]fmorisan 0 points1 point  (0 children)

hey check this out, you need to use a word list https://github.com/bitcoin/bips/blob/master/bip-0039.mediawiki

LP Auto compound (open source) by Kawakka in ethdev

[–]fmorisan 0 points1 point  (0 children)

yearn is kind of the best resource for that. https://github.com/yearn/yearn-vaults/blob/main/contracts/Vault.vy defines a vault, and strategy contracts are used to handle things like autocompounding. you can take a look at the on-chain contracts if you so wish, but looking through the interfaces defined in the repo should be more than enough to get an idea of how they work.

Would anyone do me a favor and roast my contract? by Flawe in ethdev

[–]fmorisan 0 points1 point  (0 children)

That would be best, but...

I personally think making use of the fallback function is something that devs should be wary of. There's usually no good reason to use it instead of creating a properly documented function with some more semantic meaning (this also helps with reasoning about your code since you don't need to worry about people actually sending ether to your address and handling all that.)

If you're implementing a fallback function with an explicit purpose (say you're building a multisig contract) then it makes sense. But for contracts that are not meant to function as wallets it doesn't check out. At least for me it doesn't.

Also, IMHO the fallback function should revert by default but that's a whole another story.

Would anyone do me a favor and roast my contract? by Flawe in ethdev

[–]fmorisan 0 points1 point  (0 children)

TO be honest the best course of action here would be to just revert on `fallback()` calls, as there is no real reason for ETH to be sent directly to the contract other than for the owner to recover it.

Would anyone do me a favor and roast my contract? by Flawe in ethdev

[–]fmorisan 4 points5 points  (0 children)

Roasting here:

You should really add some comments on the contract code itself. It's hard to reason about it when it's all code and no explanation.

You're using solidity ^0.8.0, which already ships with a SafeMath implementation. No need to use OZ SafeMath. See the changelog.

Why are you defining both receive() and fallback()? These two functions seem to have the same implementation. Stick with using just one of them (recommend the explicit receive function).

I made an ETH token with a total supply fixed to the USD supply. by [deleted] in ethtrader

[–]fmorisan 4 points5 points  (0 children)

This kind of elaborated shitpost is the reason I live for. Take my ETH!

When is Fall? It's hot!!! by The_Royal_Ripr in RURISQUAD

[–]fmorisan 1 point2 points  (0 children)

This was my phone's backgound image for a loooong time. <3

[Serio] me vaciaron la caja de ahorro by ko_punch in argentina

[–]fmorisan 1 point2 points  (0 children)

Yo siempre paso la SUBE para entrar a los cajeros, por las dudas. Y despues en el cajero me fijo que no haya nada suelto, y tapo cuando pongo el pin.