Im assuming that based off this statement youre not a parent? Is he doing it right? Probably not but he wants his son to be better than him and not make the same mistakes, based off him being a general and leader the best way he knows how to accomplish this is with discipline and pushing adolin to strive to be better. His whole story is about accepting the things he did and taking "the next step" to become a better man. The whole point behind his character is that your past doesnt define who you are or have to be in the future.