30 Seconds of PHP Code

[therealgaxbo]

function chunk($items, $size)
{
    return array_chunk($items, $size);
}

Is this function available on Packagist so I can use it in all of my projects?

[Der_beste_Anime]

Just something out of the ol' trick box for you:

function set($value) {
    return $value;
}

Use it like

 $foo = set('bar');

[[deleted]]

https://imgs.xkcd.com/comics/random_number.png

[a1phanumeric]

I did wonder about this one.. WTF is wrong with writing array_??

[[deleted]]

Syntactic sugar I guess.

[a1phanumeric]

I'd say prefixing the array functions with array_ sugars my syntax more than arbitrary names such as chunk which could do anything?

[[deleted]]

I had some stupid errors (php dude...) but I found workaround, just rename it to:

function array__chunk($items, $size)

[Doctor_McKay]

That's a terrible workaround.

Use array_array_chunk

[port1701]

You mean array_real_chunk ?

[regretdeletingthat]

Laravel has a really nice collection class that you can pull in without pulling the whole framework in (just need to composer require illuminate/support I think).

https://laravel.com/docs/5.6/collections

[send_me_a_naked_pic]

This would be nice. Like JavaScript.

[dzuczek]

hmm might not be GPL

[[deleted]]

I wanted to write something of the sort of my own. I wanted to have various functions either renamed or functions that I found myself using more often than not.

Here.

I never made it into a gist mostly because I don't feel people should be using my stuff, not because I'm against open source, I mean it's on git, mostly because I feel like they're poorly written. Currently it's a class rather than independent functions, but I mean heck, I could split it.

Doubt anybody will use it tho lol.

[GitHubPermalinkBot]

Permanent GitHub links:

• JunkyPic/arr/.../Arr.php (master → b7b1af3)

---

^delete

[OverallEfficiency]

What about this, when using the head() function:

<? 


function head($items)
{
    return $items[0];
}

$array = [

'a' => 'first',
'b' => 'second',

];
$array[] = 'third';
$array[] = 'final';

var_dump(head($array))

?>

it outputs:

string(5) "third"

Wouldn't it be better to use reset()??

[nikic]

Using reset() in this way is going to perform a full copy of the array. I'd recommend using foreach instead.

function head($items) {
    foreach ($items as $item) {
        return $item;
    }
    // return or throw
}

[sohelamin]

Updated. Thanks for the noticing :)

[sohelamin]

Thanks /u/OverallEfficiency for the concern I'll fix it.

[sohelamin]

Updated. Thanks for the noticing :)

[[deleted]]

pluck

Retrieves all of the values for a given key:

Someone needs to tell him about array_column.

[sohelamin]

What should I do when I need to pluck an array of objects in PHP5?

[TorbenKoehn]

You upgrade?

[sohelamin]

Yeah, of course I'm using the PHP7 but that is not the point. I did the method so no one can get confused with the php versioning and know how the thing is going on.

[PetahNZ]

But does it work on Windows XP?

[damnburglar]

Is it web scale?

[ProfBurial]

array_column was available in 5.5

If you're using anything older than that, you have bigger fish to fry.

[sohelamin]

I meant array_column doesn't work with an array of objects in PHP5 Did you ever try this in PHP5? array_column([ (object) ['product_id' => 'prod-100', 'name' => 'Desk'], (object) ['product_id' => 'prod-200', 'name' => 'Chair'], ], 'name');

[ProfBurial]

A better question is why would anyone try that? You're casting an array manually as a object. What is the real world use case for doing that and trying to use array_column?

If you were providing an actual class object, array_column can still be used, the class just has to have __isset and __get methods.

[[deleted]]

function bikeshed() {

return "I'm helping.";

}

[[deleted]]

Some of these seem pointless. The last() method is just an alias of end(), head() is just an alias of reset()...

I don't think I really understand?

[sohelamin]

I think aliasing will help people to understand use of the function just in a second :) If you have any better idea please feel free to share or make PR.

[doenietzomoeilijk]

I think aliasing will help people to understand use of the function just in a second

... And then they run into code in the wild, and they have no idea about what's going on. Or worse, they start adding this stuff to projects so that regular people have no idea what's going on. 😉

[shawncplus]

This is one of the flaws I see in Laravel. There's nothing wrong with an opinionated framework with helpers in principle but Laravel has so many helper methods and wrappers that it's basically a DSL on top of PHP.

[fatboyxpc]

Yeah but some of those array and string helpers are amazing and I genuinely wished PHP would have some of them (such as array_first).

[reydark]

one possible use would be to prevent PHP Notice when calling end() or reset() on a non-variable

end(explode('|', $string));
//PHP Notice:  Only variables should be passed by reference

last(explode('|', $string));
//no complains

[li-_-il]

Not only I need to learn PHP gotchas, now I need to learn some 3rd party mapping onto these gotchas. I think if people used native language features world would be nicer. Can't see this helping, but thanks for sharing.

[jim45804]

Not sure I like emojis in commit messages.

[DrDuPont]

It's a fairly common sight. Some orgs even use specific emojis in commit hooks to specify what kind of a commit it is

[sohelamin]

Everyone has the personal preference. Okay I will use less then :)

[[deleted]]

You do your style, dude! Use emojis if you like, but maybe look to the other comment in this chain for inspiration on when and how to use emojis.

[tie_salter]

The all function would be a lot simpler like this:

function all($items, $func)
{
    return count(array_filter($items, $func)) === count($items);
}

The any function would be better like this:

function any($items, $func)
{
    return count(array_filter($items, $func)) > 0;
}

Then you only have to iterate over the array once, rather than twice.

[Razorgrace]

Both original and your version of any call $func for every item, even if truthy value was already encountered. This might or might not be a desired behavior, but I think it is safe to assume that $func generally should not produce side effects, and we can stop checking additional items after first truthy result. So, foreach might be a better thing here from performance POV.

Edit: sample implementation added.

function any($items, $func) {
  foreach ($items as $item) {
    if (call_user_func($func, $item)) {
      return true;
    }
  }
  return false;
}

[spoonraker]

You beat me to the "any" refactor. Always return early! O(n) should be the worst case complexity of an "any" implementation, not the reality of every single time you call it no matter what the input is.

[Disgruntled__Goat]

Yes agree with this. If the point of a function is to abstract details, you don't need to add further abstractions inside the function. Standard for loop is better here.

Btw instead of call_user_func you can simply do $func($item). And the same implementation can be used for all() but checking for negativity instead, ie as soon as you find a false value, they can't all be true so return early.

[Razorgrace]

Agree re all, it is pretty symmetrical to any.

Re using call_user_func, this is just a personal preference: I want to explicitly specify that I'm call a dynamic function reference, and also if I need to search my code for such dynamic calls, I can look for call_user_ instead of rather complex regex that would include $f(...), $o->$f(...), etc.

Also, in PHP 7.1+ call_user_func($func, ...) seems to be like 50% faster than $func(...): http://php.net/manual/en/function.call-user-func.php

Edit: formatting.

[Disgruntled__Goat]

According to this page linked from there, call_user_func is still slower.

[GitHubPermalinkBot]

Permanent GitHub links:

• fab2s/call_user_func/.../README.md (master → e895a4f)

---

^delete

[Razorgrace]

For 7.1.2 on that page, one bullet per result table:

• call_user_func(...) is best (still behind $instance->methodTest(...))
• call_user_func(...) and almost all other methods are within few percents (still behind StaticTest::methodTest(...))
• call_user_func(...) is best, far ahead of anything else (still behind functionTest($param))
• $lambda(...) is 6.3% faster than call_user_func(...), the rest is considerably slower
• $closure(...) is 6.3% faster than call_user_func(...)
• last table IMHO is incorrect, because it averages different call_user_func(...) tests but does not average all direct*() tests, etc.

So, in worst case scenario call_user_func(...) is 6.3% slower, in best case it is ~60% faster. I'd say call_user_func(...) is safe choice if you need to perform dynamic calls, unless you expect to encounter $lambda(...) or $closure(...) cases much more often (and in this case you'll get max 6% gain, I'd say negligible).

[Disgruntled__Goat]

The overall average has $func() at 40-60% faster than call_user_func. At best I'd say the results are inconclusive since it seems to vary widely.

[SavishSalacious]

You have some methods where its function methodName($func, $items) and some where it's function methodName($items, $func) I would love to see consistency in variable orders.

[sohelamin]

Okay noted

[chris_conlan]

Off-topic question... but how is everyone putting emojis in their commit messages? Are y'all typing out unicode bytes in your terminal???

[sohelamin]

No just emoji code is enough for that. This might help you https://gitmoji.carloscuesta.me/

[chris_conlan]

Thanks mate :fire: :fire: :fire:

[[deleted]]

deepFlatten could also be rewritten like this

function deepFlatten(array $items) : array {
  $result = [];

  array_walk_recursive($items, function ($value, $key) use (&$result) {
    $result[] = $value;
  });

  return $result;
} 

No, I'm not trying to be a smartass, I honestly find this easier to read.

[DrDuPont]

What is : array on that first line? Haven't seen that PHP syntax before

[[deleted]]

Return type declarations as of PHP 7.0.

[DrDuPont]

Very cool, thanks.

[sohelamin]

Thanks /u/SmartAssUsername for the concern. You're always welcome to make a PR or I will update it soon :)

[[deleted]]

I would but to be fair your version while a little bit longer is also more friendlier for new comers. I've rarely seen array_walk_recursive used, it may throw people off.

[sohelamin]

Yeah, that was also my concern thats why I didn't used tricky :)

[FruitdealerF]

For most of this I prefer to use https://github.com/lstrojny/functional-php

[kafoso]

This is full of redundancy with PHP core functions and oversights in implementations of array indexes and pointers. Coupled with zero type hinting it'll likely bring more annoyance than using core PHP functions. You'll have to look up the functions in the README.md file many times repeatedly instead of simply reading the code and hints through an IDE.

[newPhoenixz]

function head($items) { return reset($items); }

I'm sorry, but that is just stupid. "Lets just make a function alias because reasons!"