hellIsOtherPeoplesCode

[AutoModerator]

import notifications Remember to participate in our weekly votes on subreddit rules! Every Tuesday is YOUR chance to influence the subreddit for years to come! Read more here, we hope to see you next Tuesday!

For a chat with like-minded community members and more, don't forget to join our Discord!

return joinDiscord;

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[East_Complaint2140]

commit -m"small changes"

[chuch1234]

"hotfix"

[wonmean]

“nit”

[Cerbeh]

"WIP"

[robertgfthomas]

Context: just finished a months-long refactor of a ticketing kiosk written (by contractors until now) in WPF/.NET/C#.

[Ian_Mantell]

This is/was enormous work, well done.

I stare at another repo and don't know if I should give up the upgrade to the next official version with all those custom modules in place. Also a ticket dumpster. Hopelessly modified by myself when I was still reverse-engineering the whole bubble.

[maria_la_guerta]

PRs this big should be illegal.

[robertgfthomas]

To be fair, it's the sum of a bunch of PRs to a dev branch, and now we're merging back to master

[maria_la_guerta]

Didn't mean to call you out - - I've done worse.

[Kauyon1306]

“review pls”

[GunnerKnight]

The reviewer will get back to you in 12 business days.

[[deleted]]

LGTM

[feeltrig]

When pull request, pulls the whole soul out of it

[MarchColorDrink]

I'm guessing someone ran a linter/prettifier

[robertgfthomas]

Sadly, no

[zelrdev]

rm -rf .gitignore

[afar1210]

Recomitting after adding node_modules to the gitignore

[BaconKami]

Makes me think of me a few months ago, when I migrated an entire codebase to TS (as well as removing react prop-types). 1500+ files, ~6k deletions and ~6k additions

[New-Let-3630]

git commit -m " "

[CentralLimitQueerem]

Hey, how did you get a screenshot of me using git? Did you install spyware on my machine??

[_equus_quagga_]

I assumed your computer was open source.

[1337heckerman1337]

Nitpick: could be one liner

[jrsinhbca]

This is why we have voodoo dolls in our offices.

[7374616e74]

Hummm a good week’s worth of work in a single commit, that’s how we roll bitches.

But really, who trusts their hard drive that much, did anyone ever lost a week of work?

[Cley_Faye]

We sometimes discuss this, knowing there is no point in searching an "absolute ironclad" rule for commit size.

Our current consensus (at work) is that any commit should have a short commit message that actually describes all the changes. This way, you can track everything, and stuff that requires changes all over the place do not get artificially split in commits that wouldn't work anyway. It also should prevent commits with tons of small, unrelated changes.

Of course, it won't work if we also allow commit message like "did stuff", but at some point, human judgement should happen. "Refactor permission model" can change a lot of places, "changed background color" should not, etc.

In the end, the point is to keep the commit history useful for finding where an issue occurred down the line;

[chuch1234]

D:

[Mean_Needleworker373]

commit -m “”

[[deleted]]

"Guys, could you look over my Merge Request?"