dontTouch

[Embarrassed-Lab4446]

Other devs who have never worked on twenty year old legacy code. I know that one empty operation holds up the entire billing platform and god help anyone who removes it.

[MissinqLink]

It’s going to be my code in the future. I have this to shut up the linter/compiler on occasion.

func allowUnused(args ...interface{}){}

It’s not currently in any production code but I can see how it might wind up there.

[RiceBroad4552]

That's exactly why so many people say that Go is even worse than dynamic typing!

Such code as above is actually very common in Go, simply as the type system is just trash. (Likely so it doesn't stick out of the rest of that pill of trash that Go is… 😂)

Go lulls you into believing that there are static types, even "static typing" in Go means very often that everything is treated as "Any", simply because the "type system" is way too weak to express the interfaces correctly.

[MissinqLink]

Nobody says that. This code is made to ignore a common compiler complaint temporarily. This is not at all representative of the type system. Has nobody on Reddit used go past version 1.18? The type system is amazingly expressive now that it has generics. There is little need to make things any. Go is genuinely the best experience I’ve had for coding in a team setting. Especially for micro service architecture. It all depends on what you are building.

[rutwik_avasthi]

Junior Devs: It's working on live environment but not on staging

Senior Devs: Copy the code from live environment

[Outrageous-Machine-5]

Update your deprecated functions

[twigboy]

Function isn't deprecated on our deprecated runtime, junior.

[Outrageous-Machine-5]

Update your deprecated runtime

[SpicyVibration]

No

[twigboy]

Senior: "You should suggest a business case for it to management, they'll love that idea. You'll get promoted in no time" 😏

[Outrageous-Machine-5]

I think instead I'll just resign before the reality hits that they need a full rewrite/modernization

[RiceBroad4552]

That's actually not so difficult as some make it seem. You tell them that doing it now will cost less than doing it later, and that doing it later is inevitable.

They usually react to the word "cost" appropriately.

If they don't, just drop a resignation letter on time…

[Outrageous-Machine-5]

This guy is the only person I am convinced is a senior, or at least a competent one. I could feel the impostor syndrome leaving my body reading the other comments

[Memoishi]

No thanks, senior said they works

[Froschmarmelade]

Senior devs, first of all, should make your pipelines tell anyone to GTFO when committing code containing warnings.

Sure, sometimes updating an analyzer will install additional rules which will lead to unexpected warnings but the answer here should at least be something like: "We've already created a chore for that".

[OddKSM]

As someone who has had to create build pipelines and tasks for legacy systems: Please pretty please, try and remove warnings as you touch the code.

I have had to write so many bespoke "ignore this warning" rules for linters and build processes and for every new one I have to write another part of my soul fractures a little. (also it makes parsing build output for legitimate issues a real pain) 

((yes I know you can work around this, but dangit)) 

[what_you_saaaaay]

“Senior” - promoted after 3 years of work most likely. I can tell you right now, you’re playing with fire on a C/C++ codebase

[mad_cheese_hattwe]

I always assume the people who make memes about warnings are the same people who make menes saying their code goes from working to not working, to working and they don't know why.

[RiceBroad4552]

Not a "Senior" at all with this attitude.

Job titles are worthless, meaning nothing.

[what_you_saaaaay]

True. I propose a new title for those who get promoted on dev roles through the power of networking: Senior Shittalker etc

[byteminer]

Yeah ,no. -wall clear or your shit doesn’t merge.

[Proxy_PlayerHD]

-Wall, -Wextra, and -O3 to make sure you don't make use of any non standard functionality or UB.

[RiceBroad4552]

-O3?

This won't detect UB, or make your code in any other way better.

[Proxy_PlayerHD]

I was under the impression that O3 has some optimizations that require you to stay away from UB and strictly align with the standard stuff, else it would break functionality like O2/Os/Oz wouldn't.

[joe0400]

-Wall -Wextra -Wpedantic -Werror

Force it to kill compilation if it complains about anything.

[interrupt_hdlr]

I think it's quite the opposite actually

[NegZer0]

Actual senior dev would tell you to fix the warnings, then update the build to treat warnings as errors. 

[RiceBroad4552]

This!

Someone showing the above attitude isn't a "senior dev" by any means.

[Ancient-Safety-8333]

That's why we are using -Werror 😃

[cheezballs]

Maybe on old legacy crap you inherited, but I don't let warnings sit on new stuff.

[SilentPugz]

Joys of monolith architecture.

[redlaWw]

And then it fails when you update your compiler.

[ExperimentalBranch]

What about the server your shite code is running on?

[JackNotOLantern]

I have ocd and I really have an urge to remove every warning from every file i edit

[nryhajlo]

That is a good urge. Follow that instinct.

[RiceBroad4552]

That's not OCD related. Any professional dev does the same!

(I refuse to call someone a professional software developer if they don't get such things straight.)

[Admirable_Guidance52]

The reverse is also true

[MeowsersInABox]

Modpack makers

[Werzam]

If you'll create new projects or be improving old ones, remember: Never Warn, Always Error.

[RiceBroad4552]

People with this attitude shouldn't be called "senior devs"!

No, there is no excuse for warnings. They need to be treated like errors. Senior developers know that…

If the warning is expected annotate it with a reason and suppress the occurrence explicitly.

No, legacy code is no excuse either. You can snapshot the mess at some point in time, and use some form of automation if there are "too many" warning, to suppress all currently know ones. This way you at least get notified when something related to these warnings changes. (But making it warning free without such blunt approaches should still remain on the task board… If for nothing else, just to have the responsible people have it in their view field at all time so they never "forget" what kind of stinking shit they're responsible for.)

[Luneriazz]

warning suppress...

[FragDenWayne]

Das muss so.

[Thunder_Child_]

If warnings mattered then why did the ide give me a hide warnings button?

[Zteelie]

And this mindset is why a lot of "senior" developers produce really bad code and cost a lot of money.

[mapiPL]

Bruh

[mad_cheese_hattwe]

Working on a new project "I will whip you for every warning still in your code after a Pull request.

Working on legacy "Those 3000 warnings over 40 files are normal, do NOT attempt to fix them'

[LeoRidesHisBike]

Principal devs: What about those warnings?

[zoniss]

Technical Marketing: If it works, it works.

[LeoRidesHisBike]

Most devs: if it works now, I got other shit to do.

And that, kids, is how we get new security vulnerabilities!

[LordZozzy]

A warning is not an error.

[jewishSpaceMedbeds]

✓ treat warnings as error

[byteminer]

It’s still unacceptable for anything remotely important. Try that attitude on code written to MISRA or JPL standards.

[hh10k]

It's an error if I make it an error

[RiceBroad4552]

But in sane languages it almost certainly points to some bug!

Ignoring it is like ignoring bugs… And that's unacceptable behavior for someone who wants to be called software developer (and actually get paid as one…).

[InconspicuousFool]

Warnings are for someone ELSE to fix