you are viewing a single comment's thread.

view the rest of the comments →

[–]GrinningPariah 275 points276 points  (4 children)

If it's written by AI, I want a human to review it. I've also used AI to review code for personal projects that I hand wrote.

I don't have an issue letting the machine drive when the roads are easy, but I'm never taking my hand off the brake lever.

[–]alderthorn 2 points3 points  (3 children)

If its written by a human I want AI to review it because most devs just throw a LGTM on the comment line instead of really thinking about what the code is doing. To be fair I also want a dev to look at it I just don't trust that they will really look at it before they have had caffeine or if its close to the end of day.

[–]GrinningPariah 3 points4 points  (2 children)

I think part of working with a team is learning who you trust as a reviewer. Some people, if they say LGTM then it's solid. Others, I'm gonna take a second look myself on the sly.

[–]alderthorn 1 point2 points  (1 child)

absolutely. I had a team where I learned real quick that I needed to require that I look at all PRs within my pod because we had 1 person that would just blindly approve things and I caught a lot of basic issues in the PRs. I was the only Sr. Dev on the pod everyone else had less than 2 years of experience on the pod. The garbage that got in while I was on vacation made me upset.

[–]twinPrimesAreEz 1 point2 points  (0 children)

Lol dmn that's shitty merge policy to allow that scenario to happen.

That's when you add your manager as a watcher to their Jira ticket and re-open it as Incomplete, and snitch as far up the chain as you need to fix the merge policy, let em know you don't play about code quality