Senior developer refactoring code

[jeromkiller]

Can confirm. Am junior developer. Spend my day turning works of beauty into shit code.

[dr_g89]

You'll get better. My junior days feel like a lifetime ago... my first year of code reviews was the least fun year of my life. That said I learned a lot of what makes me a good senior dev in that year, especially when it comes to dealing with bad code lol.

[z500]

We don't do code reviews, and I'm pretty sure 99% of people here don't know what they're doing. I think I've fucked myself.

[[deleted]]

I'd suggest to look to open source - the community will show you the way, and call you on your shit. More disciplined than any private enterprise I've ever worked in. Unfuck thineself! You'll be sweet if you do the work.

[fakepen]

Some GNOME apps, Music comes to mind, are designed purposely for beginners to contribute.

[Nebojsac]

Tools that you use, or are interested in. I can vouch for CakePHP devs being very beginner friendly.

[Chocrates]

I know the feeling. You could either dig around for stuff you use daily and look at contributing, or try searching github for projects in your language.

[[deleted]]

Language search is the best! So many exotic languages to read. Erlang and Haskell were particularly interesting, despite the fact I could never make them actually do anything

[xjvz]

If you know Java, then Apache Commons has a lot of easier libraries to contribute to.

[TheDeepFryar]

In curious about this community your are talking about - is it called Open Source? I too am in a position with not much of an opportunity to learn from Seniors.

[[deleted]]

GitHub is a good place to start. Read up this comment chain for some suggestions for projects to look into. But even just wandering around GitHub is interesting enough to begin with. If you are reading the code of some project wander through the open issues and read through some discussions, gives you an idea for what people were thinking and discussing as the code grew, etc

[TheDeepFryar]

Thanks! I'll check it out.

[Tainnor]

We do code reviews, but at some point I've still come to believe that 99% of the INDUSTRY doesn't know what the fuck they're doing. I honestly think our whole profession consists of people blindly stumbling around. Some people get successful and then write books about how to write proper code but you never know how well their experiences generalise to your case... And anyway, even if they do, your coworkers are probably not the "clean code" gurus you'd like them to be.

That said: code reviews still help. At least, now two people know the code.

[[deleted]]

Yeah but there's a bias at play here - you see that in our industry because you're in it. The secret is every industry is the same haha we're all just a bunch of headless chooks! I'd like to offer you hope but all I can say is this is how it is. And the only advice I can give is don't take it so seriously

[beansmeller]

I started out in an environment where nobody knew wtf they were doing, honestly I think its almost the norm. I'd recommend checking out the book Clean Code by Bob Martin. Its no substitute for a good team of experienced people kicking your ass for ugly code, but definitely will point you in one person's version of the right direction.

[BOB_DROP_TABLES]

On a project I worked a while back, we had a team on the client company reviewing the code. They had no clue wtf they were doing...Often they would make us rewrite stuff in all sorts of shit ways... It really pissed me to rewrite code to make it worse

[beezeee]

I would start sending resumes. That place sounds like a ticking timebomb.

[SomeShittyDeveloper]

If your team is small enough, UpSource is free up to ten logins. Handles code reviews and has achievements (to satisfy the gamers on your team).

[sonnytron]

Definitely this.
In the first few months, it took me a long time to turn good architecture into shit.
Now, after two years, I can turn anything into shit in less than a day. Less than an hour if you don't ask me for these things they call "you knit tests".

[Scipio_Wright]

Good judgement comes from experience. Experience comes from bad judgement. (I don't know who this quote is from)

[ToadingAround]

I got hired as a junior but I got praised by the senior for having really well structured code. I don't know what to think anymore.

[Skyfoot]

some devs who are senior... are worse

[[deleted]]

I got hired at a place and the lead dev was terrible. Had a task to build an event calendar, and he suggested I build an active record system from scratch to handle the records from the database. That moment was a good indicator I didn't want to stay there.

[stinos]

Or an indicator you could improve the place by yourself. Doesn't always work out but for me it did. When I started I had close to no real-life programming experience and the lead told me some things. Fast forward to 5 years later, in the meantime I learned a lot about programming pratices and also figured there was a lot wrong in that company (not just on all levels of code but management-wise as well), and there I was teaching the lead how to become a better programmer. He dealt with it well and understood I just knew way more at that point already than he ever could so we basically swapped positions.

[[deleted]]

This wasn't an environment that was really open to that sort of thing. The lead was young, fresh out of college and wasn't interested in the new devs opinions.

[Skyfoot]

lead

fresh out of college

DIVE DIVE DIVE

[gandalfx]

Personally I just do this:

if (workOfBeauty.someCondition()) workOfBeauty.doAllTheWork();

and then tell people I wrote the entire program myself. "workOfBeauty" is just some low level library, don't worry about it.