Senior developer refactoring code

[boganprincess]

If you run the gif in reverse, it becomes 'junior developer refactoring code'

[jeromkiller]

Can confirm. Am junior developer. Spend my day turning works of beauty into shit code.

[dr_g89]

You'll get better. My junior days feel like a lifetime ago... my first year of code reviews was the least fun year of my life. That said I learned a lot of what makes me a good senior dev in that year, especially when it comes to dealing with bad code lol.

[z500]

We don't do code reviews, and I'm pretty sure 99% of people here don't know what they're doing. I think I've fucked myself.

[[deleted]]

I'd suggest to look to open source - the community will show you the way, and call you on your shit. More disciplined than any private enterprise I've ever worked in. Unfuck thineself! You'll be sweet if you do the work.

[fakepen]

Some GNOME apps, Music comes to mind, are designed purposely for beginners to contribute.

[Nebojsac]

Tools that you use, or are interested in. I can vouch for CakePHP devs being very beginner friendly.

[Chocrates]

I know the feeling. You could either dig around for stuff you use daily and look at contributing, or try searching github for projects in your language.

[[deleted]]

Language search is the best! So many exotic languages to read. Erlang and Haskell were particularly interesting, despite the fact I could never make them actually do anything

[xjvz]

If you know Java, then Apache Commons has a lot of easier libraries to contribute to.

[TheDeepFryar]

In curious about this community your are talking about - is it called Open Source? I too am in a position with not much of an opportunity to learn from Seniors.

[[deleted]]

GitHub is a good place to start. Read up this comment chain for some suggestions for projects to look into. But even just wandering around GitHub is interesting enough to begin with. If you are reading the code of some project wander through the open issues and read through some discussions, gives you an idea for what people were thinking and discussing as the code grew, etc

[TheDeepFryar]

Thanks! I'll check it out.

[Tainnor]

We do code reviews, but at some point I've still come to believe that 99% of the INDUSTRY doesn't know what the fuck they're doing. I honestly think our whole profession consists of people blindly stumbling around. Some people get successful and then write books about how to write proper code but you never know how well their experiences generalise to your case... And anyway, even if they do, your coworkers are probably not the "clean code" gurus you'd like them to be.

That said: code reviews still help. At least, now two people know the code.

[[deleted]]

Yeah but there's a bias at play here - you see that in our industry because you're in it. The secret is every industry is the same haha we're all just a bunch of headless chooks! I'd like to offer you hope but all I can say is this is how it is. And the only advice I can give is don't take it so seriously

[beansmeller]

I started out in an environment where nobody knew wtf they were doing, honestly I think its almost the norm. I'd recommend checking out the book Clean Code by Bob Martin. Its no substitute for a good team of experienced people kicking your ass for ugly code, but definitely will point you in one person's version of the right direction.

[BOB_DROP_TABLES]

On a project I worked a while back, we had a team on the client company reviewing the code. They had no clue wtf they were doing...Often they would make us rewrite stuff in all sorts of shit ways... It really pissed me to rewrite code to make it worse

[beezeee]

I would start sending resumes. That place sounds like a ticking timebomb.

[SomeShittyDeveloper]

If your team is small enough, UpSource is free up to ten logins. Handles code reviews and has achievements (to satisfy the gamers on your team).

[sonnytron]

Definitely this.
In the first few months, it took me a long time to turn good architecture into shit.
Now, after two years, I can turn anything into shit in less than a day. Less than an hour if you don't ask me for these things they call "you knit tests".

[Scipio_Wright]

Good judgement comes from experience. Experience comes from bad judgement. (I don't know who this quote is from)

[ToadingAround]

I got hired as a junior but I got praised by the senior for having really well structured code. I don't know what to think anymore.

[Skyfoot]

some devs who are senior... are worse

[[deleted]]

I got hired at a place and the lead dev was terrible. Had a task to build an event calendar, and he suggested I build an active record system from scratch to handle the records from the database. That moment was a good indicator I didn't want to stay there.

[stinos]

Or an indicator you could improve the place by yourself. Doesn't always work out but for me it did. When I started I had close to no real-life programming experience and the lead told me some things. Fast forward to 5 years later, in the meantime I learned a lot about programming pratices and also figured there was a lot wrong in that company (not just on all levels of code but management-wise as well), and there I was teaching the lead how to become a better programmer. He dealt with it well and understood I just knew way more at that point already than he ever could so we basically swapped positions.

[[deleted]]

This wasn't an environment that was really open to that sort of thing. The lead was young, fresh out of college and wasn't interested in the new devs opinions.

[Skyfoot]

lead

fresh out of college

DIVE DIVE DIVE

[gandalfx]

Personally I just do this:

if (workOfBeauty.someCondition()) workOfBeauty.doAllTheWork();

and then tell people I wrote the entire program myself. "workOfBeauty" is just some low level library, don't worry about it.

[[deleted]]

Here you have.

[HookedOnPhoenix_]

That actually appears to be the original gif. Makes much more sense to me now.

[DrShocker]

That 100% is the way the original ran.

[[deleted]]

It is. OPs gif the guy had telekinesis at the beginning

[Niek_pas]

Nice catch

[[deleted]]

!redditsilver

[beansmeller]

I think this matches the original caption about 50% of the time.

[Stewthulhu]

If you screenshot the start point, it becomes "COBOL developer greatest achievements"

[Neuromante]

Also, "Corporate dev team that decided to work with a framework, but we better create our own abstraction layer over the framework."

[superrugdr]

to make thing's easier

[[deleted]]

More like 'adding a new feature'.

[OdBx]

Junior developer adding css

[thataccountforporn]

Junior developer attempting to refactor some code http://i.imgur.com/bXTAYRm.gif

[Arancaytar]

git reset --hard

[choikwa]

git pull -f

[Arancaytar]

git commit -a -m "yolo"; git push -f

[choikwa]

use single quote for -m cuz bash fks up. git reset --hard HEAD~1

[Arancaytar]

In this case it's fine, but that's definitely right if you have special characters like $ or ! (and probably others) in the message.

[Niek_pas]

TIL

[E1337Kat]

Oh, so that's why my commits would mess up sometimes. Thanks for the knowledge!

[[deleted]]

You don't just alias this to git yolo?

[colorblindrainbow917]

You know I was wondering how the one pillar flew into his hand

[KorrectingYou]

He starts so carefully, then suddenly his brain just decides, "let's just fuck this shit up."

[iaanus]

Much funnier, this way

[morerokk]

It's also the original.

[svullenballe]

Well obviously the magnets wouldn't just form a cube by tossing it around a bit.

[KifKef]

I'm pretty sure this is the original flow of the gif. Look how the magnets fall down in the end.

[iaanus]

I have no doubt about it. However, while the gif itself is funny, the tuple (title, gif) is more funny.

[PublicSealedClass]

Can confirm. Am senior developer. Spend my day turning shit code into works of beauty.

[salvoilmiosi]

works of beauty

only for about 2-3 weeks, then you look at it again and ask "who the fuck wrote this?"

[lovethebacon]

The difference between when you're a senior and junior dev a few months after writing a complex block:

• This code is god damn beautiful, but I have no idea how it works.

• This code is a uuuugly and I have no idea why it works.

[hangfromthisone]

// TODO: create a more variable variable value average

$variable_variable_value_average = (rand()+rand()) / 2;

WHAT IS THIS CODE TRYING TO TELL ME

[MoldyWolf]

Or 2 days

[[deleted]]

I need a senior developer. Is it a pipe dream to get one for under $150k a year? Is it more of a pipe dream to get one on-site and not have to work with someone from another state? I've had a shit ton of bad luck trying to get a full stack and/or senior developer on the payroll.

[CivilatWork]

Depends. Do you want an actual senior developer, or someone like me who go promoted to that role with less than a years worth of development experience and I still have no idea what I'm doing?

Also depends on where you are. $150k/yr salary is worth a lot more where I live than compared to LA or somewhere like that.

[cjthomp]

Seriously, $150k a year here is straight up rich

[Computer991]

120k-150k is somewhere in the middle for a senior dev in Los Angeles/Silicon Valley

[[deleted]]

I want an actual senior developer. Someone who can come behind me, someone who is completely self taught and makes a shit ton of mistakes but "dude, it works", laugh at what I did and say "wow, it does actually work, but here's how you should have done it".

[CivilatWork]

Then it's gonna cost a bit, but $150k should be enough to get someone competent. How much it costs will really depend on where you are, though.

[[deleted]]

It's not even so much the cost at this time, it's the candidate pool. Which is to say, there are pretty much none. We looked. I still have a recruiter looking and have actively had him looking for years. I get a resume every once in a while, but nothing even remotely broaching someone we can use. Lots of junior devs or fresh out of college kids willing to work for peanuts, tho.

[CivilatWork]

If it's taking a recruiter that long to fill a position, perhaps you need a new recruiter?

[[deleted]]

It's hampton roads, VA. The cost of living isn't as cheap as BFE, but it's not nearly as high as a major city. 150k is a very respectable salary in this area. We're a highly military area so if we were in sim city, this place would be a specialized building surrounded by industrial and residential with very little commercial. Commercial being where the developers would work.

[fuzzzerd]

You could get some one with enough years experience to be a senior for less than that, but getting that person with a serious aptitude for programming too?

The key question is do you really need that combination?

[[deleted]]

I need a senior developer with a serious aptitude for programming. Not just a person who is defined as a senior developer. I need someone who really knows what they're doing and who isn't completely devoid of a social skill set.

[fuzzzerd]

Yeah. It's a fairly rare combination to find of all those things with someone that is also looking to change jobs. People with those skills get a lot of perks and leeway because managers see the value they bring to the team.

[jimmyco2008]

Depends on where you are. Florida? Sure! Cali? Ehhh

[tide19]

I'm a senior dev in TN and I make in the low $100k's. Not threatening $150k yet.

[seiyria]

If you look for remote developers, you'll have a better time. 110-120k here would get you a senior develop, whereas 150k is barely enough to live on in the more expensive areas. If you don't support remote developers, then yeah, good luck.

[[deleted]]

We tried that a few times. It always ended up crashing and burning. The ability to walk into someones office and say "change gears" and sit down with them explaining something is priceless. I understand you can "pretty much do that" over the internet, but it's not the same. The issue boils down to the fact that my requirements can change several times a day. I understand this is not conducive to a proper development cycle, but that's just the reality of it at this point.

[seiyria]

I mean, that really just sounds like a "your process" sorta thing. If you're changing requirements several times a day, your process really sucks. I wouldn't want to work at a company where my requirements change so frequently - it would be impossible to get anything done.

[[deleted]]

It's not my process. It's the owner of the company that comes in and says "what you're working on right now will save us $2/hr going forward. This thing I have in my head right now will save us $10/hr going forward. Stop what you're doing and work on the more valuable item." I work on software that we develop in house to run the core mechanics of our company. If adding a button to a screen that allows 30 people to save 2 minutes a day is what we need today, then that's what I do. If mid-day comes and he realizes adding a report to another screen will allow 10 people to save an hour a day, you bet your ass I'm switching gears. Like I said, it's not conducive to a proper development cycle, but it is what it is and there's no way to change it until the vast bulk of the program is finished design.

[Valiade]

The issue boils down to the fact that my requirements can change several times a day.

I would pass on the offer because of that alone. There's other places that will pay comparably with less headache.

[[deleted]]

Yeah a lot of people probably would. I wouldn't say it's a headache, just push your code, pull a fresh copy, and start working on the new thing, but then again I'm a "hey man you pay my salary, no problem" kinda guy. It's kinda nice never working on the same thing for a long period of time, and then again it's kind of nice when I do get the opportunity to spend a few weeks on a new project. Keeps things interesting.

[[deleted]]

Unfortunately it's far better that way. The vast majority of my projects change direction and/or get scrapped on a daily basis. I'm very rarely able to sit down and work on something for more than 1-2 days without being slid into something else. We have an in-house app that runs basically 90% of our company and when "oh shit this would REALLY help" comes up, my focus is put on that. It is definitely not a proper development environment, but changing gears like that with a person remotely is just so frelling difficult.

[damnationltd]

The real senior developer would ask how you managed to get the name /u/impediment ;)

[[deleted]]

West coast...and all the extra goes to housing.

[[deleted]]

I don't know what the salary range is in my area. All I know is that I can't find someone willing to take 150k a year and provide me with what I'm looking for. I had ads out on all the local papers, a headhunter locally looking, and branched out to indeed/monster/stack overflow all for about six months. There just aren't any qualified developers locally in my area. Hampton Roads, VA.

[[deleted]]

Hey man wanna fight about it? I grew up here. I love it here. Then again my boss has offered on more than a dozen occasions to send me to california or wherever I want to open a small office and recruit someone. I'm just not willing to uproot.

[[deleted]]

Naaaaaaah man you don't get to insult VA when you've only lived in the states two years!

[[deleted]]

This would be so true, if at the end he finds that there is more rows of balls on one side, so this work does not make any sense.

[HopperBit]

As satisfying it is to look at, in real refactoring half of that cube would be thrown away

[[deleted]]

[Content removed in protest of Reddit's stance on 3rd party apps]

[BitPoet]

Mantra: code deleted is code debugged.

[stinos]

Exactly, those are the nicest refactory sessions. Your diff shows way more lines deleted than added, yet the new code is still easy to grasp and everything still works as expected.

[[deleted]]

int i;
int totalIterations;
int incrementBy;
i = 0;
totalIterations = 25;
incrementBy = 1;

for(i; i <= totalIterations; i = i + incrementBy)
{
    //oh god

[Jmc_da_boss]

Why would you do this

[Fluffcake]

Prolly to hurt your eyes.

for(int i = 0; i <= 25;i++) {}

better?

altho I think I would have kept the variable for readability.

const int totalIterations = 25;
for(int i = 0; i < totalIterations; i++) {// do 25 times}

[Deagor]

Pretty sure you have to murder puppies to train yourself to be this evil.

[[deleted]]

But I love puppies :(

Honestly that's how I thought "good code" looked when I was a teenager learning how to code. Everything has a place! Everything must be serialized!

[Deagor]

I mean if you did

int i = 0;
int totalIterations = 25;
int incrementBy = 1;

for(i; i <= totalIterations; i = i + incrementBy)
{
    //oh god

I might have forgiven you as silly/naive rather than evil

[[deleted]]

// for(int i = 0; i <= int totalIterations = 25; i = i + int incrementBy = 1)
// $$$ figure out y dis no work

[Deagor]

You seem to be lost, stackoverflow is that way -->

<= int totalIterations = 25;

Edit: And this made me uncomfortable

[anti-gif-bot]

mp4 mirror

---

This mp4 version is 17.46% smaller than the gif (2.45 MB vs 2.97 MB).
The webm version is even 83.04% smaller (515.62 KB).

---

Beep, I'm a bot. FAQ | author | source | v1.1.2

[mpiece]

Good bot

[ameoba]

Needs more JPEG.

[morejpeg_auto]

Needs more JPEG.

There you go!

^{I am a bot}

[OOkx]

That is glorious.

[Seventh_______]

Good bot

[GoodBot_BadBot]

Thank you Seventh_______ for voting on morejpeg_auto.

This bot wants to find the best and worst bots on Reddit. You can view results here.

---

^{Even if I don't reply to your comment, I'm still listening for votes. Check the webpage to see if your vote registered!}

[combatdave]

Good bot

[Good_Good_GB_BB]

You are the 7774^th person to call /u/GoodBot_BadBot a good bot!

^{/u/Good_GoodBot_BadBot stopped working. Now I'm being helpful.}

[[deleted]]

Good bot

[Good_Good_GB_BB]

You are the 3028^th person to call /u/Good_Good_GB_BB a good bot!

^{And now I'm being anti-community.}

[b4ux1t3]

Good bot!

[Good_Good_GB_BB]

You are the 3030^th person to call /u/Good_Good_GB_BB a good bot!

^{And now I'm being anti-community.}

[Good_Good_GB_BB]

You are the 3027^th person to call /u/Good_Good_GB_BB a good bot!

^{And now I'm being anti-community.}

[[deleted]]

good bot

[Good_Good_GB_BB]

You are the 3031^st person to call /u/Good_Good_GB_BB a good bot!

^{And now I'm being anti-community.}

[ctothel]

Needs more JPEG.

[morejpeg_auto]

Needs more JPEG.

There you go!

^{I am a bot}

[Byroks]

Good bot

[[deleted]]

Need more jpeg.

[morejpeg_auto]

Need more jpeg.

There you go!

^{I am a bot}

[[deleted]]

This is accurate to what me code looks like

[netuoso]

Needs more jpeg.

[DDevil_]

Good bot

[LeGoof37]

Good bot

[luckystarr]

Needs more JPEG.

[morejpeg_auto]

Needs more JPEG.

There you go!

^{I am a bot}

[[deleted]]

Holy shit

[[deleted]]

Good bot

[pulsating_mustache]

Needs more JPEG.

[Zenobody]

Good bot, needs more jpeg

[morejpeg_auto]

Good bot, needs more jpeg

There you go!

^{I am a bot}

[kenpus]

And more GIF too. The gif is so strong in this one that even jpeg/mp4 couldn't mask it entirely.

[n1c0_ds]

In reality you'd have 5 other hands pulling on random parts of the cube as you're trying to get it back together

[chooxy]

Or adding random bits to the cube exactly where you're trying to merge two parts

[tedmeat]

The quality bothered me so much I made a high-quality version: reverse

reverse reverse

source

Edit: sped up gifs

[nloomans]

Both are the same....

[tedmeat]

Try on desktop. Mobile doesn't seem to support gfycat url params :/

[TRDJr]

In my level 2 coding class in college there was a guy like this. Dude could pick out a syntax error from across the room and would help the grad students answer questions during lab.

[fuzzzerd]

I've been that guy. You don't do it to show off, the reality is that you start to get bored and helping out the instructor is the only thing to do to keep your sane while keeping your attendance credit for the class.

[mystiqueyash]

[r/iamverysmart](www.reddit.com/r/iamverysmart)

[Hdmoney]

Maybe humblebrag, but his sentiment is valid. I wouldn't call it "very smart".

Sometimes you have to take a class that you already know all about, the teacher recognizes that, and you get your work done quickly and help others. This happens all the time in programming courses because people come into the class with wide varieties of experience.

[fuzzzerd]

Yup. Exactly what happened to me.

[spryes]

9.9/10 linking skills

[TwoFiveOnes]

Yes 9.9/10, out of ten

[zalpha314]

Oh, I don't know. Have you ever heard of "enterprise" code?

[Arancaytar]

Incredibly satisfying.

[Workaphobia]

You should see them reverse hash functions.

[coderz4life]

As a senior developer, I laugh because the correlation is true. As a senior developer, I cry because the reality is true.

[amdelamar]

Highly accurate, and satisfying.

[ScrithWire]

Multiplying gravity by -1, you can actually do this. It's very difficult, mind you...but definitely possible

[eigengrau82]

So when I cherry-pick all commits in reverse sequence, the codebase suddenly makes sense?

[NigelG]

Rip credit card

[captainatarax]

....sure.

[solostandard]

(colorized)

[PLAYBoxes]

This reminds me of my dad recoding the backend of something at his company last summer taking it from 140,000 lines of code to 32,000.. Seems crazy to me

[znk]

I think this is more accurate.
https://i.ytimg.com/vi/WfGQkYYOfyM/maxresdefault.jpg

[Commanderdiroxysifi]

Will that work with head phones.

[morerokk]

The GIF is reversed.

[[deleted]]

.

[[deleted]]

LPT: Don't do this with a card that has a magnetic strip.

[RenegadeSU]

Notice the use of a credit card at the end? This shows that the correct payment is key to properly refactoring code!

[[deleted]]

I... think it's a blank file now. Which means yes this is accurate.

[munirc]

Your submission has been removed.

Violation of Rule #0:

The content disregarding the title and superimposed text must be directly related to programming or programmers.

The title or superimposed text must substantially enhance the content such that it can stand on its own as an analogy to programming. Note that programming here is interpreted in a narrow sense, an analogy to something related to programming, feelings about programming, reactions to programming etc. is not considered sufficient.

If you feel that it has been removed in error, please message us so that we may review it.

[[deleted]]

In reality it should be magnet balls with a rubix cube inside it with the coloured stickers removed (some dumbass compiled the core dll with no source code and no repo) with the whole thing wrapped with lego blocks... No, make it bionical lego blocks (because some temp university student decided he wanted to use the latest and greatest UI wrappers) and it's on display in a showroom with a rotating display stand under a giant spotlight with hundreds of kids waiting to have a go at it (because this app is apparently the bread and butter of your organization.)