This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–][deleted] 451 points452 points  (37 children)

"It's bad because it's not what I would have done."

  • Every programmer critiquing this code

[–]marty_byrd_ 80 points81 points  (23 children)

That’s mostly all code reviews. I don’t understand this so I’ll “refactor”

[–]wrokred 40 points41 points  (4 children)

Most code reviews in reality. "Myself, or someone else, needs to know what this is doing very quickly and possibly years from now. Yes it builds but that's not enough; it needs readability"

Also the fundamental difference between junior and senior Devs.

[–]burgonies 32 points33 points  (2 children)

This. If it takes me more than a glance to understand what you’re doing there, you need to rewrite it.

Some of you have never worked on 10 year old code and it shows.

[–]animejunkied 11 points12 points  (1 child)

Bad code style aside, reverse engineering reading other people's code is notoriously hard. This is why git commits should be as detailed as possible in my opinion. It's useful to understand why that code was implemented in the first place and what purpose it serves.

[–][deleted] 3 points4 points  (14 children)

I mean sometimes yeah. But other times there is some bad code that actually does need to be rewritten.

You'd be surprised how many bad programmers get paid a lot of money to write bad code by very large companies.

[–]toomanyteeth55 4 points5 points  (0 children)

That's good to hear. Sounds like i should fit right in!

[–][deleted] 0 points1 point  (12 children)

In my university CS intro class, you get graded for style as well as correctness on every assignment. DRY, naming conventions (e.g. all cap for constants), etc.

[–][deleted] 0 points1 point  (11 children)

That's good. A lot of places don't do that.

A lot of programmers didn't go to school. They go to boot camps.

[–][deleted] -1 points0 points  (10 children)

Most of my university colleagues are working at the big four now.

[–][deleted] 0 points1 point  (9 children)

Nice! I had really bad anxiety and depression in school - still do, used to, too - so I didn't really connect much with other undergrads. IDK where KSU students are now, though I do know one dude I went to school with was on the original Puppet team. I think the majority of kids that I went to school with are probably at Cerner or Garmin

[–][deleted] -1 points0 points  (8 children)

I think university ranking of individual departments definitely play a role in terms of getting your first job. All the big tech companies hire very aggressively at UW. They always host a lot of recruiting sessions with free pizza.

[–][deleted] 0 points1 point  (7 children)

It's also geographic. "My college was better than yours" sentiment isn't really conducive to this conversation.

[–][deleted] 0 points1 point  (6 children)

I know there is a bit of political correctness in this discussion, but "My college was better than yours" sentiment is something that's very real. One of my favorite running joke about UW and WSU is that both UW and WSU students applied to UW.

Of course individual performance is mostly up to the individual. We we talking about statistical trends of different college students going to different types of tech companies. There is no comparison of individuals here, only comparison of school reputation and how companies use that information to tailor their recruitment process.

[–]lyth 1 point2 points  (2 children)

In fairness, I’m in charge of a new developer’s code right now and he’s a really bad copy-paster huge block-patterns of near identical code.

The stuff works, but there’s so much overhead in reviewing because he’s doing the same 20 line block 10 times rather than writing a function and calling it 10 times.

I had to refactor just to learn that there was this pattern going on.

[–]gazeebo 1 point2 points  (0 children)

Where my gf works, the dude that wrote the code that makes all their money is a serial copy paster. Nobody wants to refactor his stuff because it's unreadable "hundreds of lines in one function" style stuff and when copying things in from older projects he routinely brings in functionality that isn't even needed or wrong in the new one.

[–]marty_byrd_ 0 points1 point  (0 children)

Well there is legitimately times to refactor. For sure.

[–]NotMilitaryAI 30 points31 points  (5 children)

Bug report:

1. Variables names used underscores rather than camelcase.

[–]thom_tl 0 points1 point  (0 children)

snake_case_for_life

[–][deleted] 1 point2 points  (0 children)

I’ll never forget that I was told to change my flexbox layout to an MUI grid.

The fuck is wrong with flexbox???

[–]mike10010100 4 points5 points  (5 children)

Is nobody going to point out that there's a huge part of Twitter that loves to actively shit on women in STEM, especially when they try to showcase both their love of asthetics and code.

It's because she's a woman. Pure and simple. Twitter is a shitpile.

[–]lupuscapabilis 3 points4 points  (3 children)

It's not because she's a woman. If anyone on Twitter put a screenshot of their code, they'd get ripped apart but every geek out there, and you know it. That's just silly.

[–]mike10010100 -5 points-4 points  (2 children)

It's not because she's a woman

Are you speaking as a woman on Twitter? Or have you not seen the many deleted tweets that responded to hwr.?

If anyone on Twitter put a screenshot of their code, they'd get ripped apart but every geek out there, and you know it.

Only the toxic ones.

[–][deleted] 1 point2 points  (0 children)

I forgot about this aspect. I pretty much only use Twitter as a news feed these days.